[
https://issues.apache.org/jira/browse/YARN-11225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646131#comment-17646131
]
ASF GitHub Bot commented on YARN-11225:
---------------------------------------
goiri commented on code in PR #5185:
URL: https://github.com/apache/hadoop/pull/5185#discussion_r1045908138
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java:
##########
@@ -156,6 +172,31 @@ public void setUp() {
Assert.fail();
}
+ RouterClientRMService routerClientRMService = new RouterClientRMService();
+ routerClientRMService.initUserPipelineMap(getConf());
+ long secretKeyInterval = this.getConf().getLong(
+ RM_DELEGATION_KEY_UPDATE_INTERVAL_KEY,
RM_DELEGATION_KEY_UPDATE_INTERVAL_DEFAULT);
+ long tokenMaxLifetime = this.getConf().getLong(
Review Comment:
Can't we make all of them getTimeDuration?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
##########
@@ -46,11 +47,15 @@
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.tuple.Pair;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.security.UserGroupInformation;
import org.apache.hadoop.security.authorize.AuthorizationException;
+import org.apache.hadoop.security.token.Token;
import org.apache.hadoop.util.ReflectionUtils;
import org.apache.hadoop.util.Sets;
import org.apache.hadoop.util.Time;
import org.apache.hadoop.util.concurrent.HadoopExecutors;
+import org.apache.hadoop.yarn.api.protocolrecords.*;
Review Comment:
Expand
> [Federation] Add postDelegationToken, postDelegationTokenExpiration,
> cancelDelegationToken REST APIs for Router
> ----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-11225
> URL: https://issues.apache.org/jira/browse/YARN-11225
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0, 3.3.4
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
