[
https://issues.apache.org/jira/browse/YARN-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646886#comment-17646886
]
ASF GitHub Bot commented on YARN-11374:
---------------------------------------
slfan1989 commented on code in PR #5193:
URL: https://github.com/apache/hadoop/pull/5193#discussion_r1047899298
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/RefreshSuperUserGroupsConfigurationRequestPBImpl.java:
##########
@@ -56,8 +59,9 @@ public int hashCode() {
@Override
public boolean equals(Object other) {
- if (other == null)
+ if (other == null) {
return false;
+ }
if (other.getClass().isAssignableFrom(this.getClass())) {
return this.getProto().equals(this.getClass().cast(other).getProto());
Review Comment:
Thank you very much for helping to review the code, I will modify the code.
> [Federation] Support
> refreshSuperUserGroupsConfiguration、refreshUserToGroupsMappings API's for
> Federation
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-11374
> URL: https://issues.apache.org/jira/browse/YARN-11374
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, router
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> In this jira, we will complete the refreshSuperUserGroupsConfiguration and
> refreshUserToGroupsMappings methods of FederationRMAdminInterceptor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
