[
https://issues.apache.org/jira/browse/YARN-11400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648894#comment-17648894
]
ASF GitHub Bot commented on YARN-11400:
---------------------------------------
slfan1989 commented on code in PR #5238:
URL: https://github.com/apache/hadoop/pull/5238#discussion_r1051386469
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -717,6 +717,8 @@ public void removeOrTrackCompletedContainersFromContext(
org.apache.hadoop.yarn.server.nodemanager.containermanager.container.ContainerState.DONE))
{
context.getContainers().remove(containerId);
removedContainers.add(containerId);
+ // For the finished containers, the residual data stored in leveldb
should also be cleared
+ addCompletedContainer(containerId);
Review Comment:
From a personal point of view, I think we should not clean up during the
heartbeat. If the leveldb is not cleaned up successfully or an exception is
thrown, is the heartbeat successful or failed?
The heartbeat is mainly to report container information and trigger
scheduling, it is best not to clean up.
> The finished container data stored in state store by NodeManager should be
> cleared in the NodeManager heartbeat response
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-11400
> URL: https://issues.apache.org/jira/browse/YARN-11400
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Daniel Ma
> Priority: Minor
> Labels: pull-request-available
>
> The finished container data stored in state store by NodeManager should be
> cleared in the NodeManager heartbeat response in case of too much residual
> data stored in leveldb remains.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
