[
https://issues.apache.org/jira/browse/YARN-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651573#comment-17651573
]
ASF GitHub Bot commented on YARN-11393:
---------------------------------------
brumi1024 commented on code in PR #5201:
URL: https://github.com/apache/hadoop/pull/5201#discussion_r1056205229
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigConverter.java:
##########
@@ -310,6 +313,7 @@ private void convertCapacitySchedulerXml(FairScheduler fs) {
.withPercentages(usePercentages)
.build();
+ queueConverter.emitDefaultUserLimitFactor(fsLeafQueue,
capacitySchedulerConfig);
Review Comment:
This should ideally be called from inside the queueConverter, as this method
operates on queues themselves, not on the whole structure. This way there is no
need to get the leafQueues array.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSQueueConverter.java:
##########
@@ -215,6 +219,19 @@ private void emitPreemptionDisabled(String queueName,
FSQueue queue) {
}
}
+ public void emitDefaultUserLimitFactor(Collection<FSLeafQueue> fsLeafQueue,
CapacitySchedulerConfiguration config) {
+ fsLeafQueue
Review Comment:
There is no need to iterate through the queues, as the convertQueueHierarchy
does that. Calling this method there and checking if the queue that we're
currently converting is a leafQueue should achieve what we're trying to do.
> Fs2cs could be extended to set ULF to -1 upon conversion
> --------------------------------------------------------
>
> Key: YARN-11393
> URL: https://issues.apache.org/jira/browse/YARN-11393
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
>
> A global configuration to set the default User Limit Factor to -1 on newly
> created queues.
> To solve this is to make fs2cs (Fair Scheduler to Capacity Scheduler tool)
> add the user-limit-factor value -1 to the conversion as default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
