[ 
https://issues.apache.org/jira/browse/YARN-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648132#comment-17648132
 ] 

Peter Szucs edited comment on YARN-10926 at 1/3/23 4:17 PM:
------------------------------------------------------------

I checked the mentioned jiras and the tests in the related code changes and 
didn't see any invalid assertions in them.

For YARN-10504 there were a TODO to fix 
TestAbsoluteResourceWithAutoQueue#testAutoCreateLeafQueueCreation 
[here|#diff-1ed6d328b2546b3599468f169e823d2d411a3bdb85ea7871a8533cd205e2d311],] 
and it has been fixed in a later PR: 
[https://github.com/apache/hadoop/pull/3868]

As I saw in the last comments of YARN-10504 test issues remained in 
TestAbsoluteResourceConfiguration.testSimpleMinMaxResourceConfigurartionPerQueue
 but it was also fixed in a follow-up commit 
[here|https://github.com/apache/hadoop/commit/4f008153ef5fca9e1f71ebc7069c502e803ab1e8]


was (Author: JIRAUSER297340):
I checked the mentioned jiras and the tests in the related code changes and 
didn't see any invalid assertions in them.

For YARN-10504 there were a TODO to fix 
TestAbsoluteResourceWithAutoQueue#testAutoCreateLeafQueueCreation 
[here|[https://github.com/apache/hadoop/commit/b0eec0909772cf92427957670da5630b1dd11da0#diff-1ed6d328b2546b3599468f169e823d2d411a3bdb85ea7871a8533cd205e2d311],]
 and it has been fixed in a later PR: 
[https://github.com/apache/hadoop/pull/3868]

As I saw in the last comments of 
[YARN-10504|https://issues.apache.org/jira/browse/YARN-10504] test issues 
remained in 
TestAbsoluteResourceConfiguration.testSimpleMinMaxResourceConfigurartionPerQueue
 but it was also fixed in a follow-up commit 
[here|https://github.com/apache/hadoop/commit/4f008153ef5fca9e1f71ebc7069c502e803ab1e8
 ]

> Test validation after YARN-10504 and YARN-10506: Check if modified test 
> expectations are correct or not
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10926
>                 URL: https://issues.apache.org/jira/browse/YARN-10926
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Szilard Nemeth
>            Assignee: Peter Szucs
>            Priority: Minor
>
> YARN-10504 and YARN-10506 modified some test expectations.
> The task is to verify if those expectations are correct.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to