[
https://issues.apache.org/jira/browse/YARN-11408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677304#comment-17677304
]
ASF GitHub Bot commented on YARN-11408:
---------------------------------------
susheel-gupta commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1071075406
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java:
##########
@@ -194,6 +199,10 @@ public void testDefaultUserLimitFactor() throws Exception {
assertNull("root.users user-limit-factor should be null",
conf.get(PREFIX + "root.users." + USER_LIMIT_FACTOR));
+ assertEquals("root.users auto-queue-creation-v2.enabled", "true",
+ conf.get(PREFIX + "root.users.auto-queue-creation-v2.enabled"));
+ assertNull( "root.users auto-create-child-queue.enabled should be null",
+ conf.get(PREFIX + "root.users.auto-create-child-queue.enabled"));
Review Comment:
In class TestFSQueueConverter, there is method
testQueueWithNoAutoCreateChildQueue which checks wheather
.auto-create-child-queue.enabled is null or not but according to above comment
I need to add a property of auto-create-child-queue.enabled is true.
So do I need to add a another set of queues where
auto-create-child-queue.enabled is true or is this check really required?.
```
testQueueWithNoAutoCreateChildQueue() {
converter = builder
.withCapacitySchedulerConfig(csConfig)
.build();
converter.convertQueueHierarchy(rootQueue);
assertNoValueForQueues(ALL_QUEUES, ".auto-create-child-queue.enabled",
csConfig);
}
```
> Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor
> method
> ------------------------------------------------------------------------------------
>
> Key: YARN-11408
> URL: https://issues.apache.org/jira/browse/YARN-11408
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> It is required to add user-limit-factor to -1 only for those queues which are
> leafqueue and auto-queue-creation is disabled.
> Follow-up of YARN-11393
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
