[
https://issues.apache.org/jira/browse/YARN-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683129#comment-17683129
]
ASF GitHub Bot commented on YARN-11426:
---------------------------------------
goiri commented on code in PR #5335:
URL: https://github.com/apache/hadoop/pull/5335#discussion_r1093596818
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/Resource.java:
##########
@@ -464,7 +464,7 @@ public int compareTo(Resource other) {
@Override
public String toString() {
- return getFormattedString(String.valueOf(getMemorySize()));
+ return getFormattedString();
Review Comment:
Isn't it dangerous to do it for everything and not just for the UI?
> Improve YARN NodeLabel Memory Display
> -------------------------------------
>
> Key: YARN-11426
> URL: https://issues.apache.org/jira/browse/YARN-11426
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
> Attachments: before improvement.png, image-2023-02-01-17-55-59-037.png
>
>
> NodeLabel displays the memory information of the cluster, directly displays
> the numbers, does not display the unit information, and is not easy to
> understand.
> - before improvement
> !before improvement.png!
> * after improvement
> !image-2023-02-01-17-55-59-037.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
