[
https://issues.apache.org/jira/browse/YARN-11404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683826#comment-17683826
]
ASF GitHub Bot commented on YARN-11404:
---------------------------------------
susheel-gupta commented on PR #5295:
URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1415713461
> couple of belated comments
>
> 1. I don't see any need anywhere in the codebase to move to jupiter
assertions. It makes backporting harder without offering any tangible benefits.
> If the jupiter team chose to move classes to new packages, well, that's
their choice. But if we are going to update test asserts, assertJ is a far
better assert framework.
> It's a richer assertion syntax, generates better messages and is
already in the 3.3 line -which is why we are using for much of the new tests.
> 2, new pom imports should be added to hadoop-project and then
referenced, so we can stay on top of the changes.
>
> I'm not going to suggest rolling this back -as it's in, and it was a big
piece of work. It's just that in particular the code changes for jupiter
assertions wasn't needed and it's potentially counter-productive.
>
> What I would propose is
>
> * followup PR to move the pom declarations up
> * no new patches to move to jupiter asserts. stay on org.junit or embrace
assertJ
Hi @steveloughran,
Thanks for the comments.
I followed this previously merged pr
https://github.com/apache/hadoop/pull/4771 by @aajisaka .
I will create a followup ticket to move the pom declarations up.
> Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test
> failure
> ---------------------------------------------------------------------------------
>
> Key: YARN-11404
> URL: https://issues.apache.org/jira/browse/YARN-11404
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments:
> patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
>
>
> We need to add Junit 5 dependency in
> {code:java}
> /hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml{code}
> as the testcase TestAMWebServicesJobConf, TestAMWebServicesJobs,
> TestAMWebServices, TestAMWebServicesAttempts, TestAMWebServicesTasks were
> passing locally but failed at jenkins build in this
> [link|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5119/7/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt]
> for YARN-5607
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
