[
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685403#comment-17685403
]
ASF GitHub Bot commented on YARN-11424:
---------------------------------------
goiri commented on code in PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#discussion_r1098998010
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/SubClusterState.java:
##########
@@ -55,6 +55,10 @@ public boolean isUnusable() {
return (this != SC_RUNNING && this != SC_NEW);
}
+ public boolean isUsable() {
+ return !isUnusable();
Review Comment:
Let's remove isUnusable() and always use isUsable with ! and so on.
Negative methods are usually not recommended.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -4299,6 +4299,11 @@ public static boolean isAclEnabled(Configuration conf) {
ROUTER_PREFIX + "interceptor.allow-partial-result.enable";
public static final boolean
DEFAULT_ROUTER_INTERCEPTOR_ALLOW_PARTIAL_RESULT_ENABLED = false;
+ /** Subcluster timeout allowed by Router. **/
+ public static final String ROUTER_SUBCLUSTER_EXPIRATION_TIME =
+ ROUTER_PREFIX + "subcluster.heartbeat.expiration.time";
+ public static final long DEFAULT_ROUTER_SUBCLUSTER_EXPIRATION_TIME = 1800000;
Review Comment:
Make it TimeUnit
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java:
##########
@@ -37,12 +66,48 @@ public RouterCLI(Configuration conf) {
super(conf);
}
+ private static void buildHelpMsg(String cmd, StringBuilder builder) {
+ UsageInfo usageInfo = ADMIN_USAGE.get(cmd);
+ if (usageInfo == null) {
+ return;
+ }
+
+ if (usageInfo.args != null) {
+ String space = (usageInfo.args == "") ? "" : " ";
+ builder.append(" " + cmd + space + usageInfo.args + ": "
+ + usageInfo.help);
+ } else {
+ builder.append(" " + cmd + ": " + usageInfo.help);
+ }
+ }
+
+ private static void buildIndividualUsageMsg(String cmd, StringBuilder
builder) {
+ UsageInfo usageInfo = ADMIN_USAGE.get(cmd);
+ if (usageInfo == null) {
+ return;
+ }
+ if (usageInfo.args == null) {
+ builder.append("Usage: routeradmin [" + cmd + "]\n");
Review Comment:
If we have a StringBuilder, use append not +
> [Federation] Router AdminCLI Supports DeregisterSubCluster.
> -----------------------------------------------------------
>
> Key: YARN-11424
> URL: https://issues.apache.org/jira/browse/YARN-11424
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Router provides commands for Deregister SubCluster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
