[
https://issues.apache.org/jira/browse/YARN-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690398#comment-17690398
]
ASF GitHub Bot commented on YARN-5604:
--------------------------------------
slfan1989 commented on code in PR #5394:
URL: https://github.com/apache/hadoop/pull/5394#discussion_r1109812955
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/FederationStateStore.java:
##########
@@ -60,7 +60,21 @@ public interface FederationStateStore extends
* Load the version information from the federation state store.
*
* @return the {@link Version} of the federation state store
+ * @throws Exception an exception occurred in load version.
*/
- Version loadVersion();
+ Version loadVersion() throws Exception;
Review Comment:
Thank you for helping to review the code, I will add tests, but this pr is a
framework, I will add some simple tests. It will be implemented in
`MemoryFederationStateStore`, `SQLFederationStateStore`, and
`ZookeeperFederationStateStore` later. When these functions are completed, I
will add more test cases.
> Add versioning for FederationStateStore
> ---------------------------------------
>
> Key: YARN-5604
> URL: https://issues.apache.org/jira/browse/YARN-5604
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Subramaniam Krishnan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Currently we don't have versioning (null version) for the
> FederationStateStore.This JIRA proposes add versioning support that is needed
> to support upgrades.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
