[
https://issues.apache.org/jira/browse/YARN-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700439#comment-17700439
]
ASF GitHub Bot commented on YARN-11424:
---------------------------------------
slfan1989 commented on code in PR #5363:
URL: https://github.com/apache/hadoop/pull/5363#discussion_r1136397973
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -4306,18 +4306,18 @@ public static boolean isAclEnabled(Configuration conf) {
ROUTER_PREFIX + "interceptor.allow-partial-result.enable";
public static final boolean
DEFAULT_ROUTER_INTERCEPTOR_ALLOW_PARTIAL_RESULT_ENABLED = false;
+ /** Subcluster timeout allowed by Router. **/
Review Comment:
Thank you very much for your help to review the code, I will modify the code.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRouterCLI.java:
##########
@@ -49,6 +73,33 @@ protected ResourceManagerAdministrationProtocol
createAdminProtocol() {
};
}
+ private DeregisterSubClusterResponse generateSubClusterDataBySCId(String
subClusterId) {
+ // Step2. generate return data.
+ String lastHeartBeatTime = new Date().toString();
+ DeregisterSubClusters deregisterSubClusters =
+ DeregisterSubClusters.newInstance(subClusterId, "SUCCESS",
lastHeartBeatTime,
+ "Heartbeat Time > 30 minutes", "SC_LOST");
+ List<DeregisterSubClusters> deregisterSubClusterList = new ArrayList<>();
+ deregisterSubClusterList.add(deregisterSubClusters);
+
+ // Step3. return data.
+ return DeregisterSubClusterResponse.newInstance(deregisterSubClusterList);
+ }
+
+ private DeregisterSubClusterResponse generateAllSubClusterData() {
+ List<DeregisterSubClusters> deregisterSubClusterList = new ArrayList<>();
+ for (int i = 1; i <= 4; i++) {
Review Comment:
I will modify the code.
> [Federation] Router AdminCLI Supports DeregisterSubCluster.
> -----------------------------------------------------------
>
> Key: YARN-11424
> URL: https://issues.apache.org/jira/browse/YARN-11424
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Router provides commands for Deregister SubCluster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
