[
https://issues.apache.org/jira/browse/YARN-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705105#comment-17705105
]
ASF GitHub Bot commented on YARN-11376:
---------------------------------------
goiri commented on code in PR #5496:
URL: https://github.com/apache/hadoop/pull/5496#discussion_r1148598535
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
##########
@@ -20,12 +20,15 @@
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang3.NotImplementedException;
+import org.apache.commons.lang3.StringUtils;
import org.apache.hadoop.classification.VisibleForTesting;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.CommonConfigurationKeys;
import org.apache.hadoop.ipc.StandbyException;
import org.apache.hadoop.security.UserGroupInformation;
import
org.apache.hadoop.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import org.apache.hadoop.yarn.api.records.NodeId;
Review Comment:
Unused
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java:
##########
@@ -22,6 +22,9 @@
import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
import org.apache.hadoop.test.LambdaTestUtils;
import org.apache.hadoop.yarn.api.records.DecommissionType;
+import org.apache.hadoop.yarn.api.records.NodeId;
+import org.apache.hadoop.yarn.api.records.Resource;
+import org.apache.hadoop.yarn.api.records.ResourceOption;
Review Comment:
Take a look at the checkstyle report, there are a few issues:
```
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:30:import
org.apache.hadoop.yarn.api.records.NodeId;:8: Unused import -
org.apache.hadoop.yarn.api.records.NodeId. [UnusedImports]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:31:import
org.apache.hadoop.yarn.api.records.ResourceOption;:8: Unused import -
org.apache.hadoop.yarn.api.records.ResourceOption. [UnusedImports]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestableFederationRMAdminInterceptor.java:27:import
org.apache.hadoop.yarn.server.resourcemanager.MockNM;:8: Unused import -
org.apache.hadoop.yarn.server.resourcemanager.MockNM. [UnusedImports]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestableFederationRMAdminInterceptor.java:30:import
org.junit.Assert;:8: Unused import - org.junit.Assert. [UnusedImports]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java:75:
private final int GB = 1024;:21: Name 'GB' must match pattern
'^[a-z][a-zA-Z0-9]*$'. [MemberName]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java:351:
NodeId nodeId = NodeId.newInstance("127.0.0.1",1);:51: ',' is not followed
by whitespace. [WhitespaceAfter]
```
> [Federation] Support updateNodeResource、refreshNodesResources API's for
> Federation.
> -----------------------------------------------------------------------------------
>
> Key: YARN-11376
> URL: https://issues.apache.org/jira/browse/YARN-11376
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, router
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> In this jira, we will complete the updateNodeResource and
> refreshNodesResources methods of FederationRMAdminInterceptor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
