[
https://issues.apache.org/jira/browse/YARN-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710205#comment-17710205
]
ASF GitHub Bot commented on YARN-10846:
---------------------------------------
goiri commented on code in PR #4687:
URL: https://github.com/apache/hadoop/pull/4687#discussion_r1155032724
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java:
##########
@@ -324,10 +329,66 @@ public void serviceInit(Configuration conf) throws
Exception {
YarnConfiguration.DEFAULT_NM_PROCESS_KILL_WAIT_MS) +
SHUTDOWN_CLEANUP_SLOP_MS;
+ nmDispatherMetricEnabled = conf.getBoolean(
+ YarnConfiguration.NM_DISPATCHER_METRIC_ENABLED,
+ YarnConfiguration.DEFAULT_NM_DISPATCHER_METRIC_ENABLED);
+
super.serviceInit(conf);
recover();
}
+ @SuppressWarnings("unchecked")
+ protected AsyncDispatcher createContainerManagerDispatcher() {
+ dispatcher = new AsyncDispatcher("NM ContainerManager dispatcher");
+
+ if (nmDispatherMetricEnabled) {
Review Comment:
Maybe easier to read as:
```
if (!nmDispatherMetricEnabled) {
return dispatcher;
}
```
> Add dispatcher metrics to NM
> ----------------------------
>
> Key: YARN-10846
> URL: https://issues.apache.org/jira/browse/YARN-10846
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: chaosju
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
> Attachments: YARN-10846.001.patch, screenshot-1.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> base [YARN-9615|https://issues.apache.org/jira/browse/YARN-9615], add
> dispatcher metrics to NM
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
