[
https://issues.apache.org/jira/browse/YARN-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714316#comment-17714316
]
ASF GitHub Bot commented on YARN-11378:
---------------------------------------
goiri commented on code in PR #5551:
URL: https://github.com/apache/hadoop/pull/5551#discussion_r1171879611
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/CheckForDecommissioningNodesRequest.java:
##########
@@ -32,4 +34,31 @@ public static CheckForDecommissioningNodesRequest
newInstance() {
.newRecord(CheckForDecommissioningNodesRequest.class);
return request;
}
+
+ @Private
+ @Unstable
+ public static CheckForDecommissioningNodesRequest newInstance(String
subClusterId) {
+ CheckForDecommissioningNodesRequest request = Records
+ .newRecord(CheckForDecommissioningNodesRequest.class);
+ request.setSubClusterId(subClusterId);
+ return request;
+ }
+
+ /**
+ * Get the subClusterId.
+ *
+ * @return subClusterId.
+ */
+ @InterfaceAudience.Public
Review Comment:
Let's be consistent, either just Public or the whole thing.
> [Federation] Support checkForDecommissioningNodes、refreshClusterMaxPriority
> API's for Federation
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-11378
> URL: https://issues.apache.org/jira/browse/YARN-11378
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, router
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> In this jira, we will complete the
> checkForDecommissioningNodes、refreshClusterMaxPriority methods of
> FederationRMAdminInterceptor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
