[ 
https://issues.apache.org/jira/browse/YARN-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717450#comment-17717450
 ] 

ASF GitHub Bot commented on YARN-11482:
---------------------------------------

slfan1989 commented on PR #5607:
URL: https://github.com/apache/hadoop/pull/5607#issuecomment-1526938497

   Thank you very much for resolving this issue. LGTM! 




> Fix bug of DRF comparision DominantResourceFairnessComparator2 in fair 
> scheduler
> --------------------------------------------------------------------------------
>
>                 Key: YARN-11482
>                 URL: https://issues.apache.org/jira/browse/YARN-11482
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Xiaoqiao He
>            Assignee: Xiaoqiao He
>            Priority: Major
>              Labels: pull-request-available
>
> DominantResourceFairnessComparator2 was using wrong resource info to get if 
> one queue is needy or not now. We should fix it.
> {code:java}
>       boolean s1Needy = resourceInfo1[dominant1].getValue() <
>           minShareInfo1[dominant1].getValue();
>       boolean s2Needy = resourceInfo1[dominant2].getValue() <
>           minShareInfo2[dominant2].getValue();
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to