[
https://issues.apache.org/jira/browse/YARN-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718286#comment-17718286
]
ASF GitHub Bot commented on YARN-9049:
--------------------------------------
goiri commented on code in PR #5606:
URL: https://github.com/apache/hadoop/pull/5606#discussion_r1181724019
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/FederationApplicationHomeSubClusterStore.java:
##########
@@ -117,5 +117,4 @@ GetApplicationsHomeSubClusterResponse
getApplicationsHomeSubCluster(
*/
DeleteApplicationHomeSubClusterResponse deleteApplicationHomeSubCluster(
DeleteApplicationHomeSubClusterRequest request) throws YarnException;
-
Review Comment:
Let's avoid this change.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/ApplicationHomeSubCluster.java:
##########
@@ -160,7 +182,8 @@ public String toString() {
.append("ApplicationId: ").append(getApplicationId()).append(", ")
.append("HomeSubCluster: ").append(getHomeSubCluster()).append(", ")
.append("CreateTime: ").append(getCreateTime()).append(", ")
- .append("]");
+ .append("ApplicationSubmissionContext:
").append(getApplicationSubmissionContext())
+ .append(", ").append("]");
Review Comment:
A little weird we have a comma at the end.
It was there before but is that intended?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/ApplicationHomeSubCluster.java:
##########
@@ -160,7 +182,8 @@ public String toString() {
.append("ApplicationId: ").append(getApplicationId()).append(", ")
.append("HomeSubCluster: ").append(getHomeSubCluster()).append(", ")
.append("CreateTime: ").append(getCreateTime()).append(", ")
- .append("]");
+ .append("ApplicationSubmissionContext:
").append(getApplicationSubmissionContext())
Review Comment:
No specific unit tests?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/ApplicationHomeSubCluster.java:
##########
@@ -150,7 +171,8 @@ public int hashCode() {
return new HashCodeBuilder().
append(this.getApplicationId()).
append(this.getHomeSubCluster()).
- append(this.getCreateTime()).toHashCode();
+ append(this.getCreateTime()).
+ append(this.getApplicationSubmissionContext()).toHashCode();
Review Comment:
Put the `toHashCode()` in the next line to avoid changes in future changes.
> Add application submit data to state store
> ------------------------------------------
>
> Key: YARN-9049
> URL: https://issues.apache.org/jira/browse/YARN-9049
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin Chundatt
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
> Attachments: YARN-9049.001.path
>
>
> As per the discussion in YARN-8898 we need to persist trimmend
> ApplicationSubmissionContext details to federation State Store.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
