[
https://issues.apache.org/jira/browse/YARN-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720274#comment-17720274
]
ASF GitHub Bot commented on YARN-11340:
---------------------------------------
hadoop-yetus commented on PR #5403:
URL: https://github.com/apache/hadoop/pull/5403#issuecomment-1537278309
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 16m 42s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 19m 53s | | trunk passed |
| +1 :green_heart: | compile | 6m 58s | | trunk passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | compile | 6m 21s | | trunk passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | checkstyle | 1m 46s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 48s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 52s | | trunk passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javadoc | 2m 38s | | trunk passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | spotbugs | 5m 34s | | trunk passed |
| +1 :green_heart: | shadedclient | 21m 21s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 21m 42s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 38s | | the patch passed |
| +1 :green_heart: | compile | 6m 18s | | the patch passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javac | 6m 18s | | the patch passed |
| +1 :green_heart: | compile | 6m 23s | | the patch passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | javac | 6m 23s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 38s | | the patch passed |
| +1 :green_heart: | mvnsite | 2m 30s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 28s | | the patch passed with JDK
Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 |
| +1 :green_heart: | javadoc | 2m 24s | | the patch passed with JDK
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| +1 :green_heart: | spotbugs | 5m 39s | | the patch passed |
| -1 :x: | shadedclient | 21m 0s | | patch has errors when building
and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 1m 11s |
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5403/13/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt)
| hadoop-yarn-api in the patch passed. |
| -1 :x: | unit | 4m 9s |
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5403/13/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt)
| hadoop-yarn-common in the patch passed. |
| -1 :x: | unit | 3m 9s |
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5403/13/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt)
| hadoop-yarn-server-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 57s | | The patch does not
generate ASF License warnings. |
| | | 151m 4s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.conf.TestYarnConfigurationFields |
| | hadoop.yarn.event.TestAsyncDispatcher |
| | hadoop.yarn.security.TestYARNTokenIdentifier |
| | hadoop.yarn.logaggregation.TestAggregatedLogsBlock |
| | hadoop.yarn.util.timeline.TestShortenedFlowName |
| | hadoop.yarn.client.api.impl.TestTimelineClientForATS1_5 |
| | hadoop.yarn.webapp.util.TestWebServiceClient |
| | hadoop.yarn.TestContainerLaunchRPC |
| | hadoop.yarn.client.api.impl.TestTimelineClient |
| | hadoop.yarn.api.TestResourceRequest |
| | hadoop.yarn.client.TestClientRMProxy |
| | hadoop.yarn.api.TestPBImplRecords |
| | hadoop.yarn.conf.TestHAUtil |
| | hadoop.yarn.util.resource.TestResourceUtils |
| | hadoop.yarn.util.resource.TestResources |
| | hadoop.yarn.webapp.util.TestWebAppUtils |
| | hadoop.yarn.conf.TestYarnConfiguration |
| | hadoop.yarn.nodelabels.TestCommonNodeLabelsManager |
| | hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore |
| | hadoop.yarn.util.resource.TestResourceCalculator |
| | hadoop.yarn.client.api.impl.TestTimelineClientV2Impl |
| |
hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory
|
| | hadoop.yarn.TestContainerResourceIncreaseRPC |
| | hadoop.yarn.webapp.TestWebApp |
| | hadoop.yarn.api.TestResourcePBImpl |
| | hadoop.yarn.client.api.impl.TestTimelineReaderClientImpl |
| | hadoop.yarn.TestYarnServerApiClasses |
| | hadoop.yarn.server.federation.policies.router.TestRejectRouterPolicy |
| |
hadoop.yarn.server.timeline.security.TestTimelineAuthenticationFilterInitializer
|
| |
hadoop.yarn.server.federation.policies.router.TestUniformRandomRouterPolicy |
| | hadoop.yarn.TestRPC |
| |
hadoop.yarn.server.federation.policies.manager.TestRejectAllPolicyManager |
| |
hadoop.yarn.server.federation.store.impl.TestMemoryFederationStateStore |
| | hadoop.yarn.server.federation.policies.router.TestLocalityRouterPolicy
|
| | hadoop.yarn.server.api.TestServerRMProxy |
| |
hadoop.yarn.server.federation.policies.router.TestLoadBasedRouterPolicy |
| | hadoop.yarn.server.api.protocolrecords.TestProtocolRecords |
| |
hadoop.yarn.server.federation.store.sql.TestFederationMySQLScriptAccuracy |
| | hadoop.yarn.server.uam.TestUnmanagedApplicationManager |
| |
hadoop.yarn.server.federation.store.records.TestFederationProtocolRecords |
| | hadoop.yarn.server.federation.policies.manager.TestHomePolicyManager |
| | hadoop.yarn.server.federation.policies.TestRouterPolicyFacade |
| |
hadoop.yarn.server.federation.policies.amrmproxy.TestRejectAMRMProxyPolicy |
| | hadoop.yarn.server.TestAMRMClientRelayer |
| | hadoop.yarn.server.webapp.TestLogWebService |
| |
hadoop.yarn.server.federation.policies.manager.TestWeightedLocalityPolicyManager
|
| |
hadoop.yarn.server.federation.policies.amrmproxy.TestBroadcastAMRMProxyFederationPolicy
|
| | hadoop.yarn.server.federation.resolver.TestDefaultSubClusterResolver |
| | hadoop.yarn.server.federation.utils.TestFederationRegistryClient |
| |
hadoop.yarn.server.federation.policies.router.TestWeightedRandomRouterPolicy |
| |
hadoop.yarn.server.federation.store.sql.TestFederationSQLServerScriptAccuracy |
| |
hadoop.yarn.server.federation.policies.manager.TestUniformBroadcastPolicyManager
|
| |
hadoop.yarn.server.federation.policies.amrmproxy.TestLocalityMulticastAMRMProxyPolicy
|
| |
hadoop.yarn.server.federation.policies.router.TestHashBasedRouterPolicy |
| | hadoop.yarn.server.metrics.TestAMRMClientRelayerMetrics |
| |
hadoop.yarn.server.federation.store.impl.TestZookeeperFederationStateStore |
| |
hadoop.yarn.server.federation.policies.manager.TestHashBasedBroadcastPolicyManager
|
| | hadoop.yarn.server.api.protocolrecords.TestRegisterNodeManagerRequest |
| | hadoop.yarn.server.federation.policies.router.TestPriorityRouterPolicy
|
| |
hadoop.yarn.server.federation.policies.amrmproxy.TestHomeAMRMProxyPolicy |
| |
hadoop.yarn.server.scheduler.TestDistributedOpportunisticContainerAllocator |
| |
hadoop.yarn.server.federation.policies.TestFederationPolicyInitializationContextValidator
|
| |
hadoop.yarn.server.federation.policies.manager.TestPriorityBroadcastPolicyManager
|
| | hadoop.yarn.server.federation.store.impl.TestSQLFederationStateStore |
| | hadoop.yarn.server.webapp.TestLogServlet |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5403/13/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5403 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux 54a8964ac1d5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3
19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 14c6d8c49317115ad81d3912eb2c2cd70cd67a7d |
| Default Java | Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5403/13/testReport/ |
| Max. process+thread count | 2919 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U:
hadoop-yarn-project/hadoop-yarn |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5403/13/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> [Federation] Improve SQLFederationStateStore DataSource Config
> --------------------------------------------------------------
>
> Key: YARN-11340
> URL: https://issues.apache.org/jira/browse/YARN-11340
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> SQLFederationStateStore uses HikariCP, which is a very efficient thread pool,
> but currently only exposes the max-connections parameter, we need more
> configuration to control the thread pool Added minimum-idle, pool-name,
> idle-timeout, max-lifetime, connection-timeout parameter configuration to
> allow users to better use the built-in thread pool.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
