[
https://issues.apache.org/jira/browse/YARN-11497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726463#comment-17726463
]
ASF GitHub Bot commented on YARN-11497:
---------------------------------------
mudit-97 commented on code in PR #5681:
URL: https://github.com/apache/hadoop/pull/5681#discussion_r1206212258
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestResourceTrackerService.java:
##########
@@ -3222,4 +3222,89 @@ public void testDecommissionWithoutIncludeFile() throws
Exception {
rm.close();
}
+
+ /**
+ * Decommissioning with selective states for untracked nodes.
+ */
+ @Test
+ public void testDecommissionWithSelectiveStates() throws Exception {
+ // clear exclude hosts
+ writeToHostsFile(excludeHostFile, "");
+ // init conf:
+ // (1) set untracked removal timeout to 500ms
+ // (2) set exclude path (no include path)
+ // (3) enable node untracked without pre-configured include path
+ Configuration conf = new Configuration();
+
conf.setInt(YarnConfiguration.RM_NODEMANAGER_UNTRACKED_REMOVAL_TIMEOUT_MSEC,
+ 500);
+ conf.setBoolean(
+ YarnConfiguration.RM_ENABLE_NODE_UNTRACKED_WITHOUT_INCLUDE_PATH,
true);
Review Comment:
made it one line
> Support removal of only selective node states in untracked removal flow
> -----------------------------------------------------------------------
>
> Key: YARN-11497
> URL: https://issues.apache.org/jira/browse/YARN-11497
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Mudit Sharma
> Priority: Major
> Labels: pull-request-available
>
> Currently inactive nodes are removed from the Yarn local memory irrespective
> of which state they are in. This makes the node removal process not too much
> configurable
> After this patch: https://issues.apache.org/jira/browse/YARN-10854
> If autoscaling is enabled, lot many nodes go into DECOMMISSIONED state but
> still other states like LOST, SHUTDOWN are very less and systems might want
> them to be still visible on UI for better tracking
> The proposal is to introduce a new config, which when set, will allow only
> selective node states to be removed after going into untracked state.
>
> PR: [https://github.com/apache/hadoop/pull/5681]
> Any thoughts/suggestions/feedbacks are welcome!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
