[
https://issues.apache.org/jira/browse/YARN-7747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729521#comment-17729521
]
ASF GitHub Bot commented on YARN-7747:
--------------------------------------
bringhurst opened a new pull request, #5720:
URL: https://github.com/apache/hadoop/pull/5720
### Description of PR
YARN-7747 use injected GuiceFilter instances
This is a rebase of an old patch that was never merged in. Please see Jira
for more history.
### How was this patch tested?
> YARN UI is broken in the minicluster
> -------------------------------------
>
> Key: YARN-7747
> URL: https://issues.apache.org/jira/browse/YARN-7747
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Gera Shegalov
> Priority: Major
> Attachments: YARN-7747.001.patch, YARN-7747.002.patch
>
>
> YARN web apps use non-injected instances of GuiceFilter, i.e. instances
> created by Jetty as opposed by Guice itself. This triggers the [call
> path|https://github.com/google/guice/blob/master/extensions/servlet/src/com/google/inject/servlet/GuiceFilter.java#L251]
> where the static field {{pipeline}} is used instead of the instance field
> {{injectedPipeline}}. However, besides GuiceFilter instances created by
> Jetty, each Guice module generates them as well. On the injection call path
> this static variable is updated by each instance. Thus if there are multiple
> modules as it happens to be the case in the minicluster the one loaded last
> ends up defining the filter pipeline for all Jetty instances. In the
> minicluster case this is the nodemanager UI
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
