[
https://issues.apache.org/jira/browse/YARN-11509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730945#comment-17730945
]
ASF GitHub Bot commented on YARN-11509:
---------------------------------------
slfan1989 opened a new pull request, #5727:
URL: https://github.com/apache/hadoop/pull/5727
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
JIRA: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.
There is a "todo" in the
FederationInterceptor#registerAndAllocateWithNewSubClusters method. According
to the "todo" description, the request needs to be retried to other
subclusters, but changing the parameter requests in
registerAndAllocateWithNewSubClusters is not a good operation. It is better to
add retry logic here.
We don't need to worry about losing requests because when the request cannot
be satisfied, the AM of the task will continue to apply, and these requests
will be properly transferred to other clusters for execution.
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> The FederationInterceptor#launchUAM Added retry logic.
> ------------------------------------------------------
>
> Key: YARN-11509
> URL: https://issues.apache.org/jira/browse/YARN-11509
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: amrmproxy
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Minor
>
> There is a "todo" in the
> FederationInterceptor#registerAndAllocateWithNewSubClusters method. According
> to the "todo" description, the request needs to be retried to other
> subclusters, but changing the parameter requests in
> registerAndAllocateWithNewSubClusters is not a good operation. It is better
> to add retry logic here.
> We don't need to worry about losing requests because when the request cannot
> be satisfied, the AM of the task will continue to apply, and these requests
> will be properly transferred to other clusters for execution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
