[
https://issues.apache.org/jira/browse/YARN-11513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736153#comment-17736153
]
ASF GitHub Bot commented on YARN-11513:
---------------------------------------
brumi1024 commented on code in PR #5748:
URL: https://github.com/apache/hadoop/pull/5748#discussion_r1238620785
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestWorkPreservingRMRestart.java:
##########
@@ -1651,6 +1651,94 @@ public void testUAMRecoveryOnRMWorkPreservingRestart()
throws Exception {
assertUnmanagedAMQueueMetrics(qm2, 1, 0, 0, 1);
}
+ // Test behavior of an app if two same name leaf queue with different
queuePath
+ // during work preserving rm restart with %specified mapping Placement
Rule.
+ // Test case does following:
+ //1. Submit an apps to queue root.p1.test.
+ //2. During the applications is running, restart the rm and
Review Comment:
Nit: _During the applications is running_ -> While the application is running
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestWorkPreservingRMRestart.java:
##########
@@ -1651,6 +1651,94 @@ public void testUAMRecoveryOnRMWorkPreservingRestart()
throws Exception {
assertUnmanagedAMQueueMetrics(qm2, 1, 0, 0, 1);
}
+ // Test behavior of an app if two same name leaf queue with different
queuePath
+ // during work preserving rm restart with %specified mapping Placement
Rule.
+ // Test case does following:
+ //1. Submit an apps to queue root.p1.test.
+ //2. During the applications is running, restart the rm and
+ // check whether the app submitted to the queue it was submitted initially.
+ //3. Verify that application running successfully.
+ @Test(timeout = 60000)
+ public void testQueueRecoveryOnRMWorkPreservingRestart() throws Exception {
+ CapacitySchedulerConfiguration csConf = new
CapacitySchedulerConfiguration(conf);
Review Comment:
Since this test is CS related can you please add a condition to skip it if
the chosen scheduler is not CapacityScheduler?
Like above:
`if (getSchedulerType() != SchedulerType.CAPACITY) {
return;
}`
> Applications submitted to ambiguous queue fail during recovery if "Specified"
> Placement Rule is used
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-11513
> URL: https://issues.apache.org/jira/browse/YARN-11513
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Affects Versions: 3.3.4
> Reporter: Susheel Gupta
> Assignee: Susheel Gupta
> Priority: Major
> Labels: pull-request-available
>
> When an app is submitted to an ambiguous queue using the full queue path and
> is placed in that pool via a {{%specified}} mapping Placement Rule, the queue
> in the stored ApplicationSubmissionContext will be the short name for the
> queue. During recovery from an RM failover, the placement rule will be
> evaluated using the stored short name of the queue, resulting in the RM
> killing the app as it cannot resolve the ambiguous queue name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
