[ 
https://issues.apache.org/jira/browse/YARN-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736868#comment-17736868
 ] 

ASF GitHub Bot commented on YARN-11517:
---------------------------------------

slfan1989 commented on code in PR #5766:
URL: https://github.com/apache/hadoop/pull/5766#discussion_r1241152687


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
##########
@@ -879,9 +879,11 @@ private DeregisterSubClusters deregisterSubCluster(String 
reqSubClusterId) {
       SubClusterState subClusterState = subClusterInfo.getState();
       long lastHeartBeat = subClusterInfo.getLastHeartBeat();
       Date lastHeartBeatDate = new Date(lastHeartBeat);
-
+      String heartBeatTimeOut =

Review Comment:
   I will modify the code.





> Improve Federation#RouterCLI deregisterSubCluster Code
> ------------------------------------------------------
>
>                 Key: YARN-11517
>                 URL: https://issues.apache.org/jira/browse/YARN-11517
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: federation, router
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to