[
https://issues.apache.org/jira/browse/YARN-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759113#comment-17759113
]
ASF GitHub Bot commented on YARN-11537:
---------------------------------------
goiri commented on code in PR #5944:
URL: https://github.com/apache/hadoop/pull/5944#discussion_r1305924569
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/QueryFederationQueuePoliciesResponse.java:
##########
@@ -58,18 +70,38 @@ public static QueryFederationQueuePoliciesResponse
newInstance(
*/
public abstract void setTotalSize(int totalSize);
+ /**
+ * Returns the page.
+ *
+ * @return page.
+ */
@Public
@Unstable
- public abstract int getPageSize();
+ public abstract int getPage();
Review Comment:
Doesn't size make more sense?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/MockResourceManagerFacade.java:
##########
@@ -141,44 +141,11 @@
import org.apache.hadoop.yarn.exceptions.YarnException;
import org.apache.hadoop.yarn.security.AMRMTokenIdentifier;
import org.apache.hadoop.yarn.server.api.ResourceManagerAdministrationProtocol;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.AddToClusterNodeLabelsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.AddToClusterNodeLabelsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.CheckForDecommissioningNodesRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.CheckForDecommissioningNodesResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshAdminAclsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshAdminAclsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshClusterMaxPriorityRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshClusterMaxPriorityResponse;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesResourcesRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesResourcesResponse;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesResponse;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshQueuesRequest;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshQueuesResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshServiceAclsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshServiceAclsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshSuperUserGroupsConfigurationRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshSuperUserGroupsConfigurationResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshUserToGroupsMappingsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshUserToGroupsMappingsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RemoveFromClusterNodeLabelsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RemoveFromClusterNodeLabelsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.ReplaceLabelsOnNodeRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.ReplaceLabelsOnNodeResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.UpdateNodeResourceRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.UpdateNodeResourceResponse;
+import org.apache.hadoop.yarn.server.api.protocolrecords.*;
Review Comment:
Avoid
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
##########
@@ -995,6 +999,195 @@ public BatchSaveFederationQueuePoliciesResponse
batchSaveFederationQueuePolicies
throw new YarnException("Unable to batchSaveFederationQueuePolicies.");
}
+ /**
+ * List the Queue Policies for the Federation.
+ *
+ * @param request QueryFederationQueuePoliciesRequest Request.
+ * @return
Review Comment:
Complete all these.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/ResourceManagerAdministrationProtocol.java:
##########
@@ -28,40 +28,7 @@
import org.apache.hadoop.yarn.api.records.NodeId;
import org.apache.hadoop.yarn.api.records.ResourceOption;
import org.apache.hadoop.yarn.exceptions.YarnException;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.AddToClusterNodeLabelsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.AddToClusterNodeLabelsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.NodesToAttributesMappingRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.NodesToAttributesMappingResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.CheckForDecommissioningNodesRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.CheckForDecommissioningNodesResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshAdminAclsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshAdminAclsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshClusterMaxPriorityRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshClusterMaxPriorityResponse;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesResourcesRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesResourcesResponse;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshNodesResponse;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshQueuesRequest;
-import org.apache.hadoop.yarn.server.api.protocolrecords.RefreshQueuesResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshServiceAclsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshServiceAclsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshSuperUserGroupsConfigurationRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshSuperUserGroupsConfigurationResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshUserToGroupsMappingsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RefreshUserToGroupsMappingsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RemoveFromClusterNodeLabelsRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.RemoveFromClusterNodeLabelsResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.ReplaceLabelsOnNodeRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.ReplaceLabelsOnNodeResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.UpdateNodeResourceRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.UpdateNodeResourceResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.DeregisterSubClusterRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.DeregisterSubClusterResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.SaveFederationQueuePolicyRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.SaveFederationQueuePolicyResponse;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.BatchSaveFederationQueuePoliciesRequest;
-import
org.apache.hadoop.yarn.server.api.protocolrecords.BatchSaveFederationQueuePoliciesResponse;
+import org.apache.hadoop.yarn.server.api.protocolrecords.*;
Review Comment:
Avoid
> [Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.
> ------------------------------------------------------------------------------
>
> Key: YARN-11537
> URL: https://issues.apache.org/jira/browse/YARN-11537
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> In this jira, we will support list SubClusterPolicyConfiguration information
> on the command line.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
