[
https://issues.apache.org/jira/browse/YARN-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759188#comment-17759188
]
ASF GitHub Bot commented on YARN-11435:
---------------------------------------
goiri commented on code in PR #5967:
URL: https://github.com/apache/hadoop/pull/5967#discussion_r1306269910
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
##########
@@ -195,11 +194,23 @@ public static RetryPolicy createRetryPolicy(Configuration
conf) {
/**
* Returns the singleton instance of the FederationStateStoreFacade object.
+ * @param conf Configuration.
*
* @return the singleton {@link FederationStateStoreFacade} instance
*/
- public static FederationStateStoreFacade getInstance() {
- return FACADE;
+ public static FederationStateStoreFacade getInstance(Configuration conf) {
+ if(facade == null) {
Review Comment:
Can we exit early?
```
if (facade != null) {
return facade;
}
```
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/FederationPoliciesTestUtil.java:
##########
@@ -244,7 +245,7 @@ public static FederationStateStoreFacade initFacade(
List<SubClusterInfo> subClusterInfos, SubClusterPolicyConfiguration
policyConfiguration) throws YarnException {
FederationStateStoreFacade goodFacade = FederationStateStoreFacade
- .getInstance();
+ .getInstance(new Configuration());
Review Comment:
Can we have an empty getInstance() that does the new Configuration?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java:
##########
@@ -120,7 +120,7 @@ public void setUp() {
// Initialize facade & stateSore
stateStore = new MemoryFederationStateStore();
stateStore.init(this.getConf());
- facade = FederationStateStoreFacade.getInstance();
+ facade = FederationStateStoreFacade.getInstance(this.getConf());
Review Comment:
Let's be consistent with using this or not.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:
##########
@@ -195,11 +194,23 @@ public static RetryPolicy createRetryPolicy(Configuration
conf) {
/**
* Returns the singleton instance of the FederationStateStoreFacade object.
+ * @param conf Configuration.
*
* @return the singleton {@link FederationStateStoreFacade} instance
*/
- public static FederationStateStoreFacade getInstance() {
- return FACADE;
+ public static FederationStateStoreFacade getInstance(Configuration conf) {
+ if(facade == null) {
Review Comment:
Fix spaces too.
> [Router] FederationStateStoreFacade is not reinitialized with Router conf
> -------------------------------------------------------------------------
>
> Key: YARN-11435
> URL: https://issues.apache.org/jira/browse/YARN-11435
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, router, yarn
> Reporter: Aparajita Choudhary
> Assignee: Aparajita Choudhary
> Priority: Major
> Labels: pull-request-available
>
> FederationStateStoreFacade is not initialized or reinitialized with Router
> conf when used from Router's FederationClientInterceptor. Ends up connecting
> to default memory state store.
> h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
