[
https://issues.apache.org/jira/browse/YARN-11547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764416#comment-17764416
]
ASF GitHub Bot commented on YARN-11547:
---------------------------------------
goiri commented on code in PR #6055:
URL: https://github.com/apache/hadoop/pull/6055#discussion_r1323641791
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java:
##########
@@ -36,13 +37,17 @@
import org.apache.hadoop.security.SecurityUtil;
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.hadoop.service.CompositeService;
-import org.apache.hadoop.util.JvmPauseMonitor;
-import org.apache.hadoop.util.ShutdownHookManager;
-import org.apache.hadoop.util.StringUtils;
-import org.apache.hadoop.util.VersionInfo;
+import org.apache.hadoop.util.*;
Review Comment:
Avoid
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java:
##########
@@ -291,22 +296,30 @@ public static String getProxyHostAndPort(Configuration
conf) {
public static void main(String[] argv) {
Configuration conf = new YarnConfiguration();
Thread
- .setDefaultUncaughtExceptionHandler(new
YarnUncaughtExceptionHandler());
+ .setDefaultUncaughtExceptionHandler(new
YarnUncaughtExceptionHandler());
StringUtils.startupShutdownMessage(Router.class, argv, LOG);
Router router = new Router();
try {
-
- // Remove the old hook if we are rebooting.
- if (null != routerShutdownHook) {
- ShutdownHookManager.get().removeShutdownHook(routerShutdownHook);
+ GenericOptionsParser hParser = new GenericOptionsParser(conf, argv);
+ argv = hParser.getRemainingArgs();
+ if (argv.length > 1) {
Review Comment:
Don't we have better parsing?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/Router.java:
##########
@@ -291,22 +296,30 @@ public static String getProxyHostAndPort(Configuration
conf) {
public static void main(String[] argv) {
Configuration conf = new YarnConfiguration();
Thread
Review Comment:
This spacing is weird.
> [Federation] Router Supports Remove individual application records from
> FederationStateStore.
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-11547
> URL: https://issues.apache.org/jira/browse/YARN-11547
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> Similar to RM, Router should support clearing individual application from
> FederationStateStore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
