[ 
https://issues.apache.org/jira/browse/YARN-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851069#comment-13851069
 ] 

Sandy Ryza commented on YARN-1493:
----------------------------------

I took another look at the patch and noticed something else - is the app 
removed from the scheduler in all cases when the .  I.e. I don't see an 
AppRemovedSchedulerEvent fired during an AppKilledTransition.

{code}
+      app.handler.handle(new AppRemovedSchedulerEvent(app.applicationId, app
+        .getState()));
{code}
Still a few places where second line only has two instead of four spaces of 
indentation.

> Schedulers don't recognize apps separately from app-attempts
> ------------------------------------------------------------
>
>                 Key: YARN-1493
>                 URL: https://issues.apache.org/jira/browse/YARN-1493
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-1493.1.patch, YARN-1493.2.patch, YARN-1493.3.patch, 
> YARN-1493.4.patch
>
>
> Today, scheduler is tied to attempt only.
> We need to separate app-level handling logic in scheduler. We can add new 
> app-level events to the scheduler and separate the app-level logic out. This 
> is good for work-preserving AM restart, RM restart, and also needed for 
> differentiating app-level metrics and attempt-level metrics.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to