[
https://issues.apache.org/jira/browse/YARN-11582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771302#comment-17771302
]
ASF GitHub Bot commented on YARN-11582:
---------------------------------------
slfan1989 commented on code in PR #6139:
URL: https://github.com/apache/hadoop/pull/6139#discussion_r1343287506
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/TestFicaSchedulerAPP.java:
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertThat;
+import static org.hamcrest.CoreMatchers.containsString;
+
+public class TestFicaSchedulerAPP {
+
+ @Test
+ public void testGetActivedAppDiagnosticMessage() throws
IllegalAccessException, InstantiationException {
+ StringBuilder diagnosticMessage = new StringBuilder(
+ "Application is Activated, waiting for resources to be assigned
for AM");
+ getActivedAppDiagnosticMessage(diagnosticMessage);
+ assertThat("AM Resource Request information was not successfully
displayed.",
+ diagnosticMessage.toString(), containsString("AM Resource
Request ="));
+ }
+
+ // copy from FiCaSchedulerApp#getActivedAppDiagnosticMessage
+ protected void getActivedAppDiagnosticMessage(
+ StringBuilder diagnosticMessage) {
+ diagnosticMessage.append(" Details : AM Partition = ")
+ .append(" ; ")
Review Comment:
5chars.
> Improve WebUI diagnosticMessage to show AM Container resource request size
> --------------------------------------------------------------------------
>
> Key: YARN-11582
> URL: https://issues.apache.org/jira/browse/YARN-11582
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: applications, resourcemanager
> Affects Versions: 3.3.4
> Reporter: xiaojunxiang
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2023-10-02-00-05-34-337.png, success_ShowAMInfo.jpg
>
>
> When Yarn resources are insufficient, the newly submitted job AM may be in
> the state of "Application is Activated, waiting for resources to be assigned
> for AM". This is obviously because Yarn doesn't have enough resources to
> allocate another AM Container, so we want to know how large the AM Container
> is currently allocated. Unfortunately, the current diagnosticMessage on the
> Web page does not show this data. Therefore, it is necessary to add the
> resource size of the AM Container in the diagnosticMessage, which will be
> very useful for us to troubleshoise the production faults on line.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
