[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773472#comment-17773472
]
ASF GitHub Bot commented on YARN-11588:
---------------------------------------
goiri commented on code in PR #6159:
URL: https://github.com/apache/hadoop/pull/6159#discussion_r1350774738
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -230,6 +230,9 @@ public void init(String userName) {
this.executorService = new ThreadPoolExecutor(numMinThreads, numMaxThreads,
keepAliveTime, TimeUnit.MILLISECONDS, workQueue, threadFactory);
+ // Adding this line so that unused user threads will exit and be cleaned
up if idle for too long
+ this.executorService.allowCoreThreadTimeOut(true);
Review Comment:
There's a checkstyle warning here?
> Fix uncleaned threads in YARN Federation interceptor threadpool
> ---------------------------------------------------------------
>
> Key: YARN-11588
> URL: https://issues.apache.org/jira/browse/YARN-11588
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jeffrey Chang
> Priority: Major
> Labels: pull-request-available
>
> In YARN Federation a new interceptor is generated for each new user that
> calls YARN Router. This also generates a threadpool which is used to call
> YARN RM. However, when the call is finished the threadpool threads never
> exits, causing the interceptor object for the user to never be cleaned up.
> This causes an issue when the number of users is large in the YARN cluster,
> as the number of idle, uncleaned thread can reach # of users calling router
> times number of active core threads in thread pool. This causes performance
> issues in router due to too many idle threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
