[ https://issues.apache.org/jira/browse/YARN-11577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780437#comment-17780437 ]
ASF GitHub Bot commented on YARN-11577: --------------------------------------- slfan1989 commented on code in PR #6190: URL: https://github.com/apache/hadoop/pull/6190#discussion_r1374755174 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebServices.java: ########## @@ -424,7 +424,7 @@ public BulkActivitiesInfo getBulkActivities( MediaType.APPLICATION_XML + "; " + JettyUtils.UTF_8 }) @Override public AppActivitiesInfo getAppActivities(@Context HttpServletRequest hsr, - @QueryParam(RMWSConsts.APP_ID) String appId, + @PathParam(RMWSConsts.APPID) String appId, Review Comment: After comparing the code with the ResourceManager (RM), it can be confirmed that there are some issues with this part of the code. We can refer to the following code: https://github.com/apache/hadoop/blob/e4eda40ac9966a7d8488bbb0630eaa02c3f2b0e0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java#L877C3-L892C31 > Improve FederationInterceptorREST Method Result > ----------------------------------------------- > > Key: YARN-11577 > URL: https://issues.apache.org/jira/browse/YARN-11577 > Project: Hadoop YARN > Issue Type: Improvement > Components: federation > Affects Versions: 3.4.0 > Reporter: Shilun Fan > Assignee: Shilun Fan > Priority: Major > Labels: pull-request-available > > In the FederationInterceptorREST, some methods currently return null or throw > exceptions. We will ensure that the returned results are similar to those > returned by RM, handling cases of null values or exceptions gracefully. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org