[
https://issues.apache.org/jira/browse/YARN-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781865#comment-17781865
]
ASF GitHub Bot commented on YARN-11011:
---------------------------------------
goiri commented on code in PR #6211:
URL: https://github.com/apache/hadoop/pull/6211#discussion_r1379181856
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java:
##########
@@ -125,8 +125,8 @@ public static void logAndThrowException(Throwable t, String
errMsgFormat, Object
public static void logAndThrowException(String errMsg, Throwable t)
throws YarnException {
if (t != null) {
- LOG.error(errMsg, t);
- throw new YarnException(errMsg, t);
+ LOG.error(errMsg + "" + t.getMessage(), t);
Review Comment:
Can we make this cleaner?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -842,13 +842,24 @@ <R> Collection<R> invokeConcurrent(ClientMethod request,
Class<R> clazz)
// Generate parallel Callable tasks
for (SubClusterId subClusterId : subClusterIds) {
callables.add(() -> {
- ApplicationClientProtocol protocol =
getClientRMProxyForSubCluster(subClusterId);
- String methodName = request.getMethodName();
- Class<?>[] types = request.getTypes();
- Object[] params = request.getParams();
- Method method = ApplicationClientProtocol.class.getMethod(methodName,
types);
- Object result = method.invoke(protocol, params);
- return Pair.of(subClusterId, result);
+ try {
+ ApplicationClientProtocol protocol =
getClientRMProxyForSubCluster(subClusterId);
+ String methodName = request.getMethodName();
+ Class<?>[] types = request.getTypes();
+ Object[] params = request.getParams();
+ Method method =
ApplicationClientProtocol.class.getMethod(methodName, types);
+ Object result = method.invoke(protocol, params);
+ return Pair.of(subClusterId, result);
+ } catch (Exception e) {
+ Throwable cause = e.getCause();
+ if (cause != null && cause instanceof InvocationTargetException) {
+ cause = cause.getCause();
+ }
+ String errMsg = (cause.getMessage() != null) ? cause.getMessage() :
"UNKNOWN";
+ return Pair.of(subClusterId, new YarnException(
Review Comment:
Extract the exception for readability.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestableFederationClientInterceptor.java:
##########
@@ -35,8 +35,7 @@
import org.apache.hadoop.test.GenericTestUtils;
import org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableSet;
import org.apache.hadoop.yarn.api.ApplicationClientProtocol;
-import org.apache.hadoop.yarn.api.protocolrecords.SubmitApplicationRequest;
-import org.apache.hadoop.yarn.api.protocolrecords.SubmitApplicationResponse;
+import org.apache.hadoop.yarn.api.protocolrecords.*;
Review Comment:
Avoid
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -862,8 +873,11 @@ <R> Collection<R> invokeConcurrent(ClientMethod request,
Class<R> clazz)
Pair<SubClusterId, Object> pair = future.get();
subClusterId = pair.getKey();
Object result = pair.getValue();
+ if(result instanceof YarnException) {
Review Comment:
Space
> Make YARN Router throw Exception to client clearly
> --------------------------------------------------
>
> Key: YARN-11011
> URL: https://issues.apache.org/jira/browse/YARN-11011
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 3.3.1
> Reporter: Yuan Luo
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: router-error.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When router submits job to yarn, the job is rejected by yarn for some reason.
> Yarn router just throw exception to log and return not enough info to client.
> The router always throws the following non-obvious error to client:
> Exception in thread "main"
> org.apache.hadoop.yarn.server.federation.policies.exceptions.FederationPolicyException:
> No active SubCluster available to submit the request.
> To make it easy for the user to locate the cause of a job submission failure,
> we need to make Router throw the true cause of the error to the client
> clearly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
