[ 
https://issues.apache.org/jira/browse/YARN-11617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787999#comment-17787999
 ] 

ASF GitHub Bot commented on YARN-11617:
---------------------------------------

slfan1989 commented on code in PR #6283:
URL: https://github.com/apache/hadoop/pull/6283#discussion_r1399159027


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/placement/SingleConstraintAppPlacementAllocator.java:
##########
@@ -225,11 +225,13 @@ private void 
validateAndSetSchedulingRequest(SchedulingRequest
         ((SchedulingRequestPBImpl) newSchedulingRequest).getProto());
 
 
-    LOG.info("Successfully added SchedulingRequest to app="
-        + appSchedulingInfo.getApplicationAttemptId()
-        + " placementConstraint=["
-        + schedulingRequest.getPlacementConstraint()
-        + "]. nodePartition=" + targetNodePartition);
+    if (LOG.isDebugEnabled()) {

Review Comment:
   We should not need to add this condition.
   
   ```
   LOG.debug("Successfully added SchedulingRequest to app={}, 
placementConstraint={}. nodePartition={}", 
appSchedulingInfo.getApplicationAttemptId(), 
schedulingRequest.getPlacementConstraint(), targetNodePartition)");
   ```





> Noisy log in SingleConstraintAppPlacementAllocator
> --------------------------------------------------
>
>                 Key: YARN-11617
>                 URL: https://issues.apache.org/jira/browse/YARN-11617
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>            Reporter: Junfan Zhang
>            Priority: Major
>              Labels: pull-request-available
>
> Too many noisy log in SingleConstraintAppPlacementAllocator like that:
> 2023-11-20 15:14:30,493 INFO 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.placement.SingleConstraintAppPlacementAllocator:
>  Successfully added SchedulingRequest to 
> app=appattempt_1700464328807_0002_000001 placementConstraint=[
> node,EQ,nm.yarn.io/lifecycle=[reserved:true]]. nodePartition=



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to