[
https://issues.apache.org/jira/browse/YARN-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842007#comment-17842007
]
ASF GitHub Bot commented on YARN-11685:
---------------------------------------
brumi1024 commented on code in PR #6770:
URL: https://github.com/apache/hadoop/pull/6770#discussion_r1583197107
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/ResourceHandlerModule.java:
##########
@@ -69,9 +70,9 @@ public class ResourceHandlerModule {
private static volatile CGroupsHandler cGroupsHandler;
private static volatile CGroupsBlkioResourceHandlerImpl
cGroupsBlkioResourceHandler;
- private static volatile CGroupsMemoryResourceHandlerImpl
+ private static volatile AbstractCGroupsMemoryResourceHandler
Review Comment:
Nit: there might not always be an abstract parent class for every
ResourceHandler, instead we could simply return the interface like some of the
getters already do.
AbstractCGroupsMemoryResourceHandler -> MemoryResourceHandler
AbstractCGroupsCpuResourceHandler -> CpuResourceHandler
> Create a config to enable/disable cgroup v2 functionality
> ---------------------------------------------------------
>
> Key: YARN-11685
> URL: https://issues.apache.org/jira/browse/YARN-11685
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Benjamin Teke
> Assignee: Peter Szucs
> Priority: Major
> Labels: pull-request-available
>
> Various OS's mount the cgroup v2 differently, some of them mount both the v1
> and v2 structure, others mount a hybrid structure. To avoid initialization
> issues the cgroup v1/v2 functionality should be set by a config property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
