[
https://issues.apache.org/jira/browse/YARN-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857368#comment-13857368
]
Bikas Saha commented on YARN-1029:
----------------------------------
bq. The method should have been synchronized in YARN-1481, Vinod Kumar
Vavilapalli and I thought we could handle it here. Could do an addendum patch
there instead if that is preferred.
Please take care of it wherever appropriate.
bq. Not sure how advantageous that will be - we ll end up calling the common
method instead of ExitUtil.terminate only for the common method to call it?
Also, getCause() doesn't exist in AbstractEvent requiring us to add a new kind
of event (CausedEvent?) that both these events extend. Seems too complicated
for the gain.
The advantage is that future changes will need to edit one place in the code
and forget about other places. Not a major point though. Making life easier for
future devs.
bq. Agree - 100%, but would like to do it lazily when another such case pops up.
Again, if we organize the newly added code such that its a common event for any
module to inform the RM about a fatal error then we are good for the future.
Embedded elector can use that event instead of a custom named event.
I am sorry I could not understand your comment explaining how the test passes
with these timeouts. Been sick for a while. Probably my brain is running slow :P
> Allow embedding leader election into the RM
> -------------------------------------------
>
> Key: YARN-1029
> URL: https://issues.apache.org/jira/browse/YARN-1029
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Karthik Kambatla
> Attachments: embedded-zkfc-approach.patch, yarn-1029-0.patch,
> yarn-1029-0.patch, yarn-1029-1.patch, yarn-1029-2.patch, yarn-1029-3.patch,
> yarn-1029-4.patch, yarn-1029-approach.patch
>
>
> It should be possible to embed common ActiveStandyElector into the RM such
> that ZooKeeper based leader election and notification is in-built. In
> conjunction with a ZK state store, this configuration will be a simple
> deployment option.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
