[
https://issues.apache.org/jira/browse/YARN-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857888#comment-13857888
]
Vinod Kumar Vavilapalli commented on YARN-1493:
-----------------------------------------------
bq. The earlier addApplication is renamed to addApplicationAttempt, this
addApplicationAttempt is called when the SchedulerAttemptAddedEvent comes. So
we are not adding or removing any application data structure in the leaf queue
at all, we are adding/removing attempt in the leaf queue.
Yeah, that is the current state. Let's do the same to future-proof it.
bq. ParetQueueâs finishApplicationAttempt and submitApplicationAttempt logic is
empty, ParetQueue only deal with app-specific logic in the current
implementation. Do we still want to call parentQueue in attempt-specific APIs?
Again, that's today. Let's do it the way one would see it in future.
bq. YARN-1507 is saving the application after app is accepted. So after
YARN-1507, an app is saved meaning it is accepted. Maybe leave it for now and
fix it in YARN-1507 ?
Sure, you should leave a code-comment nonetheless pointing to the JIRA.
bq. I changed it to ACCEPTED state instead of RUNNING because as said after
YARN-1507, an app is saved meaning it is ACCEPTED. the app may not necessarily
be at RUNNING state earlier.
Again, let's leave a code comment saying the same.
bq. This can happen because I changed app to return ACCEPTED state on recovery,
and on recovery the app once again go through the scheduler and triggers one
more APP_ACCEPTED event at ACCEPTED state.
Ditto.
> Schedulers don't recognize apps separately from app-attempts
> ------------------------------------------------------------
>
> Key: YARN-1493
> URL: https://issues.apache.org/jira/browse/YARN-1493
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-1493.1.patch, YARN-1493.2.patch, YARN-1493.3.patch,
> YARN-1493.4.patch, YARN-1493.5.patch, YARN-1493.6.patch, YARN-1493.7.patch
>
>
> Today, scheduler is tied to attempt only.
> We need to separate app-level handling logic in scheduler. We can add new
> app-level events to the scheduler and separate the app-level logic out. This
> is good for work-preserving AM restart, RM restart, and also needed for
> differentiating app-level metrics and attempt-level metrics.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
