[
https://issues.apache.org/jira/browse/YARN-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857977#comment-13857977
]
Bikas Saha commented on YARN-1481:
----------------------------------
Its not clear why removing the synchronization is safe. This private method is
called from multiple public methods. If the earlier behavior was that the
Active state of the RM would not be visible until the locking setter method had
completely transitioned the RM to active then the new code might change that
behavior. The callers would see the RM as active as soon as the state variable
changes, even though the RM might be in the process of becoming active.
> Move internal services logic from AdminService to ResourceManager
> -----------------------------------------------------------------
>
> Key: YARN-1481
> URL: https://issues.apache.org/jira/browse/YARN-1481
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Fix For: 2.4.0
>
> Attachments: YARN-1481-20131207.txt, YARN-1481-20131209.txt,
> yarn-1481-addendum.patch, yarn-1481-addendum.patch
>
>
> This is something I found while reviewing YARN-1318, but didn't halt that
> patch as many cycles went there already. Some top level issues
> - Not easy to follow RM's service life cycle
> -- RM adds only AdminService as its service directly.
> -- Other services are added to RM when AdminService's init calls
> RM.activeServices.init()
> - Overall, AdminService shouldn't encompass all of RM's HA state management.
> It was originally supposed to be the implementation of just the RPC server.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
