[ 
https://issues.apache.org/jira/browse/YARN-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926041#comment-17926041
 ] 

ASF GitHub Bot commented on YARN-11756:
---------------------------------------

brumi1024 commented on code in PR #7324:
URL: https://github.com/apache/hadoop/pull/7324#discussion_r1951083790


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/components/yarn-queue-partition-capacity-labels.hbs:
##########
@@ -16,59 +16,255 @@
  * limitations under the License.
 }}
 
-<div class="top-1">
-  <span class="yarn-label primary">
-    <span class="label-key">absolute used</span>
+<h4>Queue Status for Partition</h4>
+{{!
+/scheduler/schedulerInfo/queues/queue[1]/resources/resourceUsagesByPartition[2]/used/resourceInformations/resourceInformation[1]/name[text()='memory-mb']
+/scheduler/schedulerInfo/queues/queue[1]/resources/resourceUsagesByPartition[2]/used/resourceInformations/resourceInformation[1]/value/text('2048')
+/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition/usedCapacity[text()='37.883835']
+}}
+<ul>
+  <li class="queues-list">
+    <span class="label-key" title=" Aka. 'Used Resources': is the total of the 
resources consumed within the queue for the given partition <memory MB, vCores, 
%>.
+    The percentage value calculated differently for the 
DefaultResourceCalculator and for the DominantResourceCalculator."><b>used 
capacity:</b></span>
+    <span class="label-value"><b>{{data.usedCapacity}}%</b></span>
+    <span class="label-value"><ul>{{#each 
data.used.resourceInformations.resourceInformation as | 
resource|}}<li>{{resource.name}}: {{resource.value}}</li>{{/each}}</ul></span>
+  </li>
+
+
+  <li class="yarn-list">
+    <span class="label-key" title="Absolute Used Capacity: percentage 
referring to the used resources from the total available resources for the 
partition">absolute used:</span>
     <span class="label-value">{{data.absoluteUsedCapacity}}%</span>
-  </span>
-  <span class="yarn-label primary">
-    <span class="label-key">absolute capacity</span>
+  </li>
+
+  {{!
+  
/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition[2]/absoluteCapacity[text()='85.44922']
+  }}
+  <li class="yarn-list">
+    <span class="label-key" title="Absolute Configured Capacity: percentage 
referring to the configured resources from the total available resources for 
the partition. This value  will be different from the configured capacity only 
when the parent queue is not the root queue.">absolute configured 
capacity:</span>
     <span class="label-value">{{data.absoluteCapacity}}%</span>
-  </span>
-  <span class="yarn-label secondary">
-    <span class="label-key">absolute max capacity</span>
+  </li>
+  {{!
+  /scheduler/schedulerInfo/queues/queue[2]/absoluteMaxCapacity[text()='100.0']
+  }}
+  <li class="yarn-list">
+    <span class="label-key" title="Absolute Configured Max Capacity: 
percentage referring to the configured maximum resources from the total 
available resources for the partition. This value will be different from the 
configured max capacity only when the parent queue is not the root 
queue.">absolute configured max capacity:</span>
     <span class="label-value">{{data.absoluteMaxCapacity}}%</span>
-  </span>
-</div>
-{{#if data.isWeightMode}}
-<div class="top-1">
-  <span class="yarn-label secondary">
-    <span class="label-key">weight</span>
-    <span class="label-value">{{data.weight}}</span>
-  </span>
-  <span class="yarn-label secondary">
-    <span class="label-key">normalized weight</span>
-    <span class="label-value">{{data.normalizedWeight}}</span>
-  </span>
-</div>
-{{else}}
-<div class="top-1">
-  <span class="yarn-label secondary">
-    <span class="label-key">configured capacity</span>
-    <span class="label-value">{{data.capacity}}%</span>
-  </span>
-  <span class="yarn-label secondary">
-    <span class="label-key">configured max capacity</span>
-    <span class="label-value">{{data.maxCapacity}}%</span>
-  </span>
-</div>
-{{/if}}
+  </li>
+
+
+  {{#if data.isWeightMode}}
+
+    <li class="yarn-list">
+      <span class="label-key" title="Configured Weight">weight:</span>
+      <span class="label-value">{{data.weight}}</span>
+    </li>
+    <li class="yarn-list">
+      <span class="label-key" title="Normalized Weight">normalized 
weight:</span>
+      <span class="label-value">{{data.normalizedWeight}}</span>
+    </li>
+
+  {{else}}
+
+    {{!
+    
/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition[2]/capacity[text()='85.44922']
+    }}
+    <li class="yarn-list">
+      <span class="label-key" title="Configured Capacity: percentage = 
'configured resources of the queue' / 'total available resources for the 
partition' * 100">configured capacity:</span>
+      <span class="label-value">{{data.capacity}}%</span>
+    </li>
+
+    {{!
+    /scheduler/schedulerInfo/queues/queue[2]/maxCapacity[text()='100.0']
+    }}
+    <li class="yarn-list">
+      <span class="label-key" title="Configured Max Capacity: percentage = 
'configured maximum resources of the queue' / 'total available resources for 
the partition' * 100">configured max capacity:</span>
+      <span class="label-value">{{data.maxCapacity}}%</span>
+    </li>
+
+    {{!
+    
/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition/configuredMinResource/memory[text()='54060']
+    
/scheduler/schedulerInfo/queues/queue[2]/capacities/queueCapacitiesByPartition/configuredMinResource/vCores[text()='5']
+    }}
+    <li class="yarn-list">
+      <span class="label-key" title="Configured min capacity">configured min 
capacity:</span>

Review Comment:
   Just to avoid complicating things, can you please use the same naming for 
these parameters as they are on UI1? Attaching a screenshot for help. In this 
case `configured min capacity` would become `Configured Capacity`. `used am 
resources` would be `Used Application Master Resources`. It's longer, but for 
the users it's easier to match the information they had on the old UI.
   
   
   <img width="884" alt="Screenshot 2025-02-11 at 16 33 50" 
src="https://github.com/user-attachments/assets/b65c07e3-4504-4cdf-a93c-df3f96c5dbbd";
 />
   





> [UI2] Add the metrics from UI1 scheduler/application queues page to UI2 
> Queues page 
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-11756
>                 URL: https://issues.apache.org/jira/browse/YARN-11756
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Ferenc Erdelyi
>            Assignee: Ferenc Erdelyi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: ui1_vs_ui2_with_YARN-11756.png, 
> ui2_resources_displayed_as_iterated_list.png, ui2_vs_ui2_with_YARN-11756.png
>
>
> UI2's Queues page lacks metrics compare to the metrics exposed on UI1's 
> Scheduler Page - Application Queues section.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to