[ 
https://issues.apache.org/jira/browse/YARN-11758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926561#comment-17926561
 ] 

ASF GitHub Bot commented on YARN-11758:
---------------------------------------

ferdelyi commented on code in PR #7331:
URL: https://github.com/apache/hadoop/pull/7331#discussion_r1953303355


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/components/queue-usage-donut-chart.js:
##########
@@ -16,29 +16,36 @@
  * limitations under the License.
  */
 
-import BaseUsageDonutChart from 'yarn-ui/components/base-usage-donut-chart';
+import DonutChart from 'yarn-ui/components/donut-chart';
 import ColorUtils from 'yarn-ui/utils/color-utils';
 import HrefAddressUtils from 'yarn-ui/utils/href-address-utils';
 
-export default BaseUsageDonutChart.extend({
+export default DonutChart.extend({
   colors: d3.scale.category20().range(),
 
   draw: function() {
     var usageByQueues = [];
     var avail = 100;
 
-    this.get("data").forEach(function (queue) {
-      var v = queue.get("absUsedCapacity");
+    let partitionFilter = this.partition;
 
+    this.get("data").forEach(function (queue) {
       if (queue.get("isLeafQueue")) {
-        if (v > 1e-2) {
-          usageByQueues.push({
-            label: queue.get("id"),
-            link: HrefAddressUtils.getQueueLink(queue.get("id")),
-            value: v.toFixed(2)
-          });
+        let partitionMap = queue.get("partitionMap");
+        console.log("partitionMap dump: ", partitionMap[partitionFilter]);

Review Comment:
   @brumi1024 thank you for the review! I've amended the code accordingly.





> [UI2] On the Cluster Metrics page make the Resource Usage by Leaf Queues 
> chart partition-aware
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-11758
>                 URL: https://issues.apache.org/jira/browse/YARN-11758
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Ferenc Erdelyi
>            Assignee: Ferenc Erdelyi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: ui2_vs_ui2_with_YARN-11758.png
>
>
> When partitions are used, the "Cluster Resource Usage By Leaf Queues" chart 
> shows data only for the default partition and does not display metrics for 
> the other partitions. Proposing to add a separate chart for each partition 
> and to re-structure the page based on categories for more clarity.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to