[ 
https://issues.apache.org/jira/browse/YARN-11757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926820#comment-17926820
 ] 

ASF GitHub Bot commented on YARN-11757:
---------------------------------------

ferdelyi commented on code in PR #7330:
URL: https://github.com/apache/hadoop/pull/7330#discussion_r1954760305


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/templates/components/partition-usage.hbs:
##########
@@ -0,0 +1,66 @@
+{!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+}}
+<div class="row">
+  <div class="col-md-12 container-fluid">
+    <div class="panel panel-default queue-page-breadcrumb" 
id="partition-usage-container">
+      <div class="panel-heading">
+        {{model.firstObject.type}} scheduler - Partition usage overview
+     </div>
+     <div class="flex">
+        {{log module.exports}}
+        {{#if (eq model.firstObject.type "capacity")}}
+
+        <table class="table table-striped table-bordered active-user-table">
+          <thead>
+            <tr>
+              <th>Partition Name</th>
+              <th>Resource Used from the Partition</th>
+              <th>Total Resource in the Partition</th>

Review Comment:
   @brumi1024 thank you for the review! I've swapped the "Partition Name" 
column title to "Node Label". Keeping the partition reference in the rest of 
the table, as the dropdown below is labelled as "Partitions" and would like to 
show consistency within a page in the naming convention, making it easier to 
follow that we are referring to the same thing. The intention with adding the 
partition usage table here is to make it easier to the user to drill down which 
partition should be checked because of e.g. high usage.





> [UI2] Add partition usage overview to the Queues page
> -----------------------------------------------------
>
>                 Key: YARN-11757
>                 URL: https://issues.apache.org/jira/browse/YARN-11757
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn-ui-v2
>            Reporter: Ferenc Erdelyi
>            Assignee: Ferenc Erdelyi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: ui1_vs_ui2_with_YARN-11757.png, 
> ui2_partition_info_with_resources_iterated_through_YARN_11757.png, 
> ui2_vs_ui2_with_YARN-11757.png
>
>
> On UI2 we won't know the overall usage within a partition until we click 
> through the partitions filter dropdown. Proposing to add a summary on top of 
> the page with the resources used and the total resources available in each 
> partition.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to