[
https://issues.apache.org/jira/browse/YARN-11765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927873#comment-17927873
]
ASF GitHub Bot commented on YARN-11765:
---------------------------------------
steveloughran commented on PR #7352:
URL: https://github.com/apache/hadoop/pull/7352#issuecomment-2664124745
There's a lot of change related to the moved import
what about one of
1. moving the relevant classes to hadoop common in the yarn package?
2. having subclasses in yarn to leave all the existing imports alone?
we did #1 for an HDFS class last year. Just move it with an explanation
> Refactor: Move Clock Class from hadoop-mapreduce-project to
> hadoop-common-project for Reusability
> -------------------------------------------------------------------------------------------------
>
> Key: YARN-11765
> URL: https://issues.apache.org/jira/browse/YARN-11765
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn, yarn-common
> Reporter: Jiandan Yang
> Assignee: Jiandan Yang
> Priority: Major
> Labels: pull-request-available
>
> *Background:*
>
> Currently, both hadoop-mapreduce-project and hadoop-yarn-project define their
> own versions of the Clock class. This leads to redundant class definitions
> across different Hadoop subprojects, reducing maintainability and code
> reusability.
>
> To {*}avoid duplicate definitions and improve class reuse{*}, we propose
> *moving the* Clock *class from* hadoop-mapreduce-project *to*
> hadoop-common-project, making it available as a shared utility for all Hadoop
> components.
>
> *Proposal:*
> 1.{*}Move the{*} Clock *interface and its implementions from*
> hadoop-mapreduce-project *to* hadoop-common-project, ensuring it becomes a
> shared utility accessible to all subprojects.
> 2. *Update all references* in hadoop-mapreduce-project and
> hadoop-yarn-project to use the newly relocated Clock class in
> hadoop-common-project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
