[
https://issues.apache.org/jira/browse/YARN-11764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927893#comment-17927893
]
ASF GitHub Bot commented on YARN-11764:
---------------------------------------
slfan1989 commented on code in PR #7345:
URL: https://github.com/apache/hadoop/pull/7345#discussion_r1958958420
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java:
##########
@@ -560,13 +560,17 @@ public void testAMRMClientMatchStorage() throws
YarnException, IOException {
}
}
- assertEquals(2, allocatedContainerCount);
+ assertTrue(allocatedContainerCount <= 2);
Review Comment:
@steveloughran @ayushtkn @Hexiaoqiao This week, I plan to focus on upgrading
`YARN` to JUnit 5. This PR needs to be merged first, as it addresses some
existing issues with the current JUnit setup. We have some disagreements
regarding the improvements to certain methods in `TestAMRMClient.java`. My
suggestion is to temporarily mark several flaky tests as "Ignore". This way, we
can prioritize advancing the JUnit 5 upgrade for YARN and revisit these
specific tests for further improvement later.
cc: @cnauroth
> yarn tests have stopped running.
> --------------------------------
>
> Key: YARN-11764
> URL: https://issues.apache.org/jira/browse/YARN-11764
> Project: Hadoop YARN
> Issue Type: Bug
> Components: gpg, nodemanager, resourcemanager
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> After completing HADOOP-15984, we added JUnit5 test dependencies to some
> modules. These dependencies caused maven-surefire to fail to recognize JUnit4
> tests, leading to the cessation of unit tests in some YARN modules. As a
> result, some YARN unit tests failed and were not detected in time. This JIRA
> will track and resolve these issues, including the stopped unit tests and
> test errors.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
