[
https://issues.apache.org/jira/browse/YARN-11258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931260#comment-17931260
]
ASF GitHub Bot commented on YARN-11258:
---------------------------------------
cnauroth commented on code in PR #7437:
URL: https://github.com/apache/hadoop/pull/7437#discussion_r1974178628
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/cache/TestFederationCache.java:
##########
@@ -63,15 +60,16 @@ public static Collection<Class[]> getParameters() {
private FederationStateStoreTestUtil stateStoreTestUtil;
private FederationStateStoreFacade facade;
- public TestFederationCache(Class cacheClassName) {
+ public void initTestFederationCache(Class cacheClassName)
Review Comment:
Can this be made `private`?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZKFederationStateStoreOpDurations.java:
##########
@@ -236,4 +237,9 @@ public void removeStoredTokenDuration(long startTime, long
endTime) {
public void getTokenByRouterStoreTokenDuration(long startTime, long endTime)
{
getTokenByRouterStoreToken.add(endTime - startTime);
}
+
+ @VisibleForTesting
+ protected ZKFederationStateStoreOpDurations resetOpDurations() {
Review Comment:
I think I understand why the `resetOpDurations` changes were made. (There's
a singleton instance holding state across test cases.) However, did something
about JUnit 5 trigger the need for this? Is it just an unrelated bug?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java:
##########
@@ -84,16 +81,17 @@ public static Collection<Boolean[]> getParameters() {
private Boolean isCachingEnabled;
- public TestFederationStateStoreFacade(Boolean isCachingEnabled) {
+ public void initTestFederationStateStoreFacade(Boolean pIsCachingEnabled)
Review Comment:
Can this be made `private`?
> Upgrade JUnit from 4 to 5 in hadoop-yarn-server-common
> ------------------------------------------------------
>
> Key: YARN-11258
> URL: https://issues.apache.org/jira/browse/YARN-11258
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
