[
https://issues.apache.org/jira/browse/YARN-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931270#comment-17931270
]
ASF GitHub Bot commented on YARN-11263:
---------------------------------------
cnauroth commented on code in PR #7390:
URL: https://github.com/apache/hadoop/pull/7390#discussion_r1974197651
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java:
##########
@@ -183,20 +182,19 @@ public class TestDockerContainerRuntime {
private final static String ENV_OCI_CONTAINER_RUN_PRIVILEGED_CONTAINER =
formatOciEnvKey(RUNTIME_TYPE, RUN_PRIVILEGED_CONTAINER_SUFFIX);
- @Rule
- public TemporaryFolder tempDir = new TemporaryFolder();
-
- @Parameterized.Parameters(name = "https={0}")
public static Collection<Object[]> data() {
return Arrays.asList(new Object[][] {
{true}, {false}
});
}
- @Parameterized.Parameter
public boolean https;
- @Before
+ public void initHttps(boolean pHttps) {
Review Comment:
Can this be made `private`?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestRuncContainerRuntime.java:
##########
@@ -160,10 +163,14 @@ public static Collection<Object[]> data() {
});
}
- @Parameterized.Parameter
public boolean https;
- @Before
+ public void initHttps(boolean pHttps) throws ContainerExecutionException {
Review Comment:
Can this be made `private`?
> Upgrade JUnit from 4 to 5 in hadoop-yarn-server-nodemanager
> -----------------------------------------------------------
>
> Key: YARN-11263
> URL: https://issues.apache.org/jira/browse/YARN-11263
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: test, yarn
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
