[
https://issues.apache.org/jira/browse/YARN-11810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943594#comment-17943594
]
ASF GitHub Bot commented on YARN-11810:
---------------------------------------
hadoop-yetus commented on PR #7605:
URL: https://github.com/apache/hadoop/pull/7605#issuecomment-2797093900
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 21s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | shadedclient | 24m 36s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | shadedclient | 19m 46s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 24s | | The patch does not
generate ASF License warnings. |
| | | 46m 25s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7605/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/7605 |
| Optional Tests | dupname asflicense codespell detsecrets |
| uname | Linux ddfd65da1b2d 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18
17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / d57d921ea2d7962014264b3aeeadb20a0807efd3 |
| Max. process+thread count | 553 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn U:
hadoop-yarn-project/hadoop-yarn |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7605/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Fix SQL script in SQLServer/FederationStateStoreTables.sql
> ----------------------------------------------------------
>
> Key: YARN-11810
> URL: https://issues.apache.org/jira/browse/YARN-11810
> Project: Hadoop YARN
> Issue Type: Bug
> Components: federation
> Affects Versions: 3.4.1
> Reporter: Peter Szucs
> Assignee: Peter Szucs
> Priority: Major
> Labels: pull-request-available
>
> The SQLServer/FederationStateStoreTables.sql script contains duplicated
> create statements and SQL syntax errors which makes
> _TestFederationSQLServerScriptAccuracy#checkSqlServerScriptAccuracy_ unit
> test fail.
>
> I see 2 issues which cause this test failure:
> # *Duplicated create statements*
> ** the test creates a SQLServerFederationStateStore class, which extracts
> and stores the "CREATE TABLE" statements from FederationStateStoreTables.sql
> with the [extractCreateTableSQL
> method|https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLServerFederationStateStore.java#L43].
> ** then iterates through the collected statements and executes them as a
> prepared statement
> [here|https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/sql/TestFederationSQLServerScriptAccuracy.java#L53]
> ** the create statements for _masterKeys_ and _delegationTokens_ tables are
> duplicated in the script, so these will be collected and attempted to be
> executed twice, which results in the following error during the test runs:
> {code:java}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.991
> s <<< FAILURE! - in
> org.apache.hadoop.yarn.server.federation.store.sql.TestFederationSQLServerScriptAccuracy
> [ERROR]
> checkSqlServerScriptAccuracy(org.apache.hadoop.yarn.server.federation.store.sql.TestFederationSQLServerScriptAccuracy)
> Time elapsed: 0.91 s <<< ERROR!
> java.sql.SQLSyntaxErrorException:
> object name already exists: MASTERKEYS in statement [CREATE TABLE masterKeys(
> keyId BIGINT NOT NULL,
> masterKey VARCHAR(1024) NOT NULL,
> CONSTRAINT pk_keyId PRIMARY KEY
> (
> keyId
> )
> )]
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.fetchResult(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.execute(Unknown Source)
> at
> com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44){code}
>
> # *Syntax errors in the SQL script*
> ** the create statements for _sequenceTable_ and versions are missing a
> comma before the constraints are defined here:
> {code:java}
> CREATE TABLE [dbo].[sequenceTable](
> sequenceName VARCHAR(255) NOT NULL,
> nextVal bigint NOT NULL
> CONSTRAINT [pk_sequenceName] PRIMARY KEY
> (
> [sequenceName]
> )
> ){code}
> and here:
> {code:java}
> CREATE TABLE [dbo].[versions](
> fedVersion VARBINARY(1024) NOT NULL,
> versionComment VARCHAR(255) NOT NULL
> CONSTRAINT [pk_fedVersion] PRIMARY KEY
> (
> [fedVersion]
> )
> ){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
