[ 
https://issues.apache.org/jira/browse/YARN-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859160#comment-13859160
 ] 

Karthik Kambatla commented on YARN-1029:
----------------------------------------

Thanks Sandy. Posted a new patch that addresses most of your comments.

bq. Why the added null check in getActiveRMIndex? When would one of the entries 
in the resourceManagers array be null?
stopResourceManager(i) stops and nullifies resourceManagers[i]. restart() 
resets this and points to a new RM. Currently, we are forced to do this because 
a stopped service can't be restarted, and the only way to trigger a failover 
automatically is to kill the RM. Have marked these two methods @Private to 
limit their access to YARN.

> Allow embedding leader election into the RM
> -------------------------------------------
>
>                 Key: YARN-1029
>                 URL: https://issues.apache.org/jira/browse/YARN-1029
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Karthik Kambatla
>         Attachments: embedded-zkfc-approach.patch, yarn-1029-0.patch, 
> yarn-1029-0.patch, yarn-1029-1.patch, yarn-1029-2.patch, yarn-1029-3.patch, 
> yarn-1029-4.patch, yarn-1029-5.patch, yarn-1029-6.patch, yarn-1029-7.patch, 
> yarn-1029-7.patch, yarn-1029-8.patch, yarn-1029-9.patch, 
> yarn-1029-approach.patch
>
>
> It should be possible to embed common ActiveStandyElector into the RM such 
> that ZooKeeper based leader election and notification is in-built. In 
> conjunction with a ZK state store, this configuration will be a simple 
> deployment option.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to