[
https://issues.apache.org/jira/browse/YARN-11361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954498#comment-17954498
]
ASF GitHub Bot commented on YARN-11361:
---------------------------------------
Hean-Chhinling commented on code in PR #7694:
URL: https://github.com/apache/hadoop/pull/7694#discussion_r2111106517
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/yarn.dt.plugins.js:
##########
@@ -159,7 +159,6 @@ function renderHadoopElapsedTime(data, type, full) {
return toReturn;
}
// 'sort', 'type' and undefined all just use the number
- return data;
Review Comment:
@riya2305 could you help explain why removing this `return data`?
> Remove jQuery dependency
> ------------------------
>
> Key: YARN-11361
> URL: https://issues.apache.org/jira/browse/YARN-11361
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Benjamin Teke
> Assignee: Riya Khandelwal
> Priority: Major
> Labels: pull-request-available
>
> jQuery nowadays has little to no benefits, but has a really high maintenance
> cost (a lot of CVE fixes result in a jQuery upgrade ticket, which then needs
> thorough manual UI testing). This task is to investigate and replace the
> jQuery JS code to vanilla JavaScript.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
