[ 
https://issues.apache.org/jira/browse/YARN-11822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954879#comment-17954879
 ] 

ASF GitHub Bot commented on YARN-11822:
---------------------------------------

p-szucs opened a new pull request, #7718:
URL: https://github.com/apache/hadoop/pull/7718

   Change-Id: Ibf2c52efe20304bf5089e1aab160b20fb7f657b0
   
   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   TestFederationProtocolRecords.testSubClusterInfoEqual unit test fails 
intermittently.
   
   It looks like a test issue that can be easily fixed: the test compares the 
results of two sequentially called Time.now() method in the SubClusterInfo, and 
expects to be equal. Using a variable that stores the current time should solve 
this issue
   
   ### How was this patch tested?
   Unit test
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> Fix flaky unit test in TestFederationProtocolRecords
> ----------------------------------------------------
>
>                 Key: YARN-11822
>                 URL: https://issues.apache.org/jira/browse/YARN-11822
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: test
>            Reporter: Peter Szucs
>            Assignee: Peter Szucs
>            Priority: Minor
>
> TestFederationProtocolRecords.testSubClusterInfoEqual unit test fails 
> intermittently.
> It looks like a test issue that can be easily fixed: the test compares the 
> results of two sequentially called Time.now() method in the SubClusterInfo, 
> and expects to be equal. Using a variable that stores the current time should 
> solve this issue



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to