[
https://issues.apache.org/jira/browse/YARN-11824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014786#comment-18014786
]
ASF GitHub Bot commented on YARN-11824:
---------------------------------------
cnauroth opened a new pull request, #7885:
URL: https://github.com/apache/hadoop/pull/7885
### Description of PR
First, make sure test libraries like jersey-test-framework-provider-jetty
are limited to scope test.
Then, update other modules that didn't know they were getting their test
dependencies through YARN to depend on test libraries explicitly.
### How was this patch tested?
I used `mvn dependency:tree` to check that the test dependencies were gone
after these changes. Before the changes, we had this in the final distro after
`mvn clean package -Pdist -Dtar -DskipTests -DskipShade`:
```
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/mapreduce/lib/mockito-junit-jupiter-4.11.0.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/yarn/lib/junit-jupiter-5.11.0.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-4.13.2.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-jupiter-engine-5.13.3.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-platform-commons-1.13.3.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-platform-engine-1.13.3.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-jupiter-params-5.13.3.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-jupiter-api-5.13.3.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/yarn/lib/hamcrest-3.0.jar
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/hamcrest-core-1.3.jar
```
After these changes, everything is gone except for the stuff in
`hadoop/tools/lib`. This is apparently intentional dependencies of
`hadoop-tools/hadoop-compat-bench`, but it won't creep into the classpath for
dependent projects like Parquet.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Prevent test dependencies from leaking into the distro.
> -------------------------------------------------------
>
> Key: YARN-11824
> URL: https://issues.apache.org/jira/browse/YARN-11824
> Project: Hadoop YARN
> Issue Type: Bug
> Components: build
> Affects Versions: 3.5.0
> Reporter: Steve Loughran
> Assignee: Chris Nauroth
> Priority: Blocker
>
> 3.5.0 builds now include a hamcrest jar
> {code}
> > find . -print | grep hamcrest
> ./licenses-binary/LICENSE-hamcrest.txt
> ./share/hadoop/tools/lib/hamcrest-core-1.3.jar
> ./share/hadoop/yarn/lib/hamcrest-3.0.jar
> {code}
> the hamcrest-3.0.jar is new, doesn't seem to be explicitly declared anywhere.
> Nor it is listed in the LICENSE-binary file.
> Some It is being exported as a dependency enough to break parquet builds
> {code}
> [INFO] --- dependency:3.7.1:analyze-only (default) @ parquet-hadoop ---
> [ERROR] Used undeclared dependencies found:
> [ERROR] org.hamcrest:hamcrest:jar:3.0:provided
> {code}
> I don't understand what the dependency analyser is/how it is configured, but
> it is unhappy, even though the scope is only provided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
