[
https://issues.apache.org/jira/browse/YARN-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019457#comment-18019457
]
ASF GitHub Bot commented on YARN-11261:
---------------------------------------
slfan1989 commented on PR #7946:
URL: https://github.com/apache/hadoop/pull/7946#issuecomment-3276937509
> > there are only a few classes left over, can you change them together?
> > ```
> > $ grep -rl --include='*.java' "import org.junit.Test" . | sort | uniq
> >
./hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/test/TestFuseDFS.java
> >
./hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java
> >
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestFedAppReportFetcher.java
> >
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServletFed.java
> > ```
>
> Thanks for the review, Pan. To keep things straightforward for the
different maintainers and CI jobs, would it be okay to split this into one PR
per module? The tests touch separate areas, so smaller PRs should make review
and potential reverts simpler. Remaining items:
>
> ```
> • hadoop-aws: ITestS3AContractSeek, ITestTreewalkProblems
> • hadoop-compat-bench: compat/cases/* (e.g., HdfsCompatAcl …
HdfsCompatTpcds)
> • hadoop-azure: ITestAbfsTerasort … ITestExponentialRetryPolicy
> • hadoop-hdfs-native-client: TestFuseDFS
> • hadoop-hdfs-rbf: TestRouterDistCpProcedure,
…/server/federation/security/token/*
> ```
@zhtttylz +1, This suggestion makes sense. To facilitate code review and
future maintenance, it's recommended to submit changes by module separately,
and avoid merging changes from multiple modules in a single commit.
> Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy
> ---------------------------------------------------------
>
> Key: YARN-11261
> URL: https://issues.apache.org/jira/browse/YARN-11261
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: test, yarn
> Affects Versions: 3.3.4
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
