[ 
https://issues.apache.org/jira/browse/YARN-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18032103#comment-18032103
 ] 

ASF GitHub Bot commented on YARN-11881:
---------------------------------------

stoty commented on PR #8046:
URL: https://github.com/apache/hadoop/pull/8046#issuecomment-3432402280

   This uses the shaded Hbase client for the hbase  client side modules: 
   **hadoop-yarn-server-timelineservice-hbase-common, 
hadoop-yarn-server-timelineservice-hbase-client**
   
   However, we need the unshaded hbase-server JAR for compiling the Hbase 
coprocessor in **hadoop-yarn-server-timelineservice-hbase-server-2**, so we use 
the unshaded Hbase jars there.
   
   For simlipicity's sake (and beacuse I'm not sure we do otherwise) we're 
still using the unshaded hbase jars for testing, as the protobuf 2.5 dependency 
is not a problem there.
   
   Hbase does provide an **hbase-shaded-testing-util** package, but I am not 
sure that works with custom coprocessors, and I didn't attempt using that.
   
   Mixing the unshaded hbase jars with the shaded client is a bad idea, so we 
exclude the shaded client when building the coprocessor and in the tests.




> Use hbase-shaded-client-byo-hadoop in hadoop-yarn-server-timelineservice-hbase
> ------------------------------------------------------------------------------
>
>                 Key: YARN-11881
>                 URL: https://issues.apache.org/jira/browse/YARN-11881
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: build, timelineservice
>    Affects Versions: 3.4.2
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>              Labels: pull-request-available
>
> The HBase timelineservice backed is currently using the unshaded HBase client.
> This brings in a lot of HBase dependencies, most critically protobuf 2.5.
> Use hbase-shaded-client-byo-hadoop which shades protobuf-java 2.5 so that it 
> won't conflict with other Protobuf versions on the classpath, and removes 
> several other dependencies from the Yarn classpath.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to