[
https://issues.apache.org/jira/browse/YARN-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18032579#comment-18032579
]
ASF GitHub Bot commented on YARN-11883:
---------------------------------------
18chanp1 opened a new pull request, #8049:
URL: https://github.com/apache/hadoop/pull/8049
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
TestResources class has indeterminism because state is not cleaned between
test.
These particular tests are affected:
org.apache.hadoop.yarn.util.resource.TestResources.testAdd
org.apache.hadoop.yarn.util.resource.TestResources.testClone
org.apache.hadoop.yarn.util.resource.TestResources.testCompareToWithNoneResource
org.apache.hadoop.yarn.util.resource.TestResources.testComponentwiseMax
org.apache.hadoop.yarn.util.resource.TestResources.testComponentwiseMin
org.apache.hadoop.yarn.util.resource.TestResources.testFitsIn
org.apache.hadoop.yarn.util.resource.TestResources.testMultiply
org.apache.hadoop.yarn.util.resource.TestResources.testMultiplyAndRoundDown
org.apache.hadoop.yarn.util.resource.TestResources.testMultiplyAndRoundUpCustomResources
org.apache.hadoop.yarn.util.resource.TestResources.testSubtract
org.apache.hadoop.yarn.util.resource.TestResourceUtils.testGetResourceTypes
This can be addressed by consistently calling existing clean up functions
after every test.
### How was this patch tested?
All existing unit tests for the class passed and continue to pass after the
change.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [X] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> TestResources class has indeterminism because state is not cleaned between
> test
> -------------------------------------------------------------------------------
>
> Key: YARN-11883
> URL: https://issues.apache.org/jira/browse/YARN-11883
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Paco Chan
> Priority: Trivial
>
> Concerns the following tests:
>
> |org.apache.hadoop.yarn.util.resource.TestResources.testAdd|
> |org.apache.hadoop.yarn.util.resource.TestResources.testClone|
> |org.apache.hadoop.yarn.util.resource.TestResources.testCompareToWithNoneResource|
> |org.apache.hadoop.yarn.util.resource.TestResources.testComponentwiseMax|
> |org.apache.hadoop.yarn.util.resource.TestResources.testComponentwiseMin|
> |org.apache.hadoop.yarn.util.resource.TestResources.testFitsIn|
> |org.apache.hadoop.yarn.util.resource.TestResources.testMultiply|
> |org.apache.hadoop.yarn.util.resource.TestResources.testMultiplyAndRoundDown|
> |org.apache.hadoop.yarn.util.resource.TestResources.testMultiplyAndRoundUpCustomResources|
> |org.apache.hadoop.yarn.util.resource.TestResources.testSubtract|
> |org.apache.hadoop.yarn.util.resource.TestResourceUtils.testGetResourceTypes
>
>
> This can be addressed by calling clean up functions after every state.|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
